Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change test files to prepare for #1874 #2091

Merged
merged 2 commits into from
Jan 28, 2023

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Oct 25, 2022

This PR takes away some of the changes in #2075 and related PRs built on that which are needed to implement #1874. This way the PRs that build on this do not have unrelated changes to isAfter.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e01385a) compared to base (7bef722).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2091   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2335      2335           
  Branches       586       586           
=========================================
  Hits          2335      2335           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WikiRik
Copy link
Member Author

WikiRik commented Oct 25, 2022

@pixelbucket-dev could you rebase on this? I've already updated the refactor of isAfter on this

Copy link
Contributor

@braaar braaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@braaar
Copy link
Contributor

braaar commented Oct 26, 2022

Would be really nice if we could merge this! That makes it a lot easier to review PRs like #2089

@pixelbucket-dev
Copy link

@tux-tn would you be able to approve so @WikiRik and I can move on with the other PRs? 😄

@rubiin rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Jan 21, 2023
@rubiin
Copy link
Member

rubiin commented Jan 23, 2023

@WikiRik mc is blocking the merge

@WikiRik
Copy link
Member Author

WikiRik commented Jan 23, 2023

@rubiin Fixed, thanks for the heads up! I'll review the PRs that allow usage of the options object after this has been merged and those PRs have been rebased

@rubiin rubiin added ✅ LGTM and removed mc-to-land Just merge-conflict standing between the PR and landing. labels Jan 23, 2023
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@profnandaa profnandaa merged commit 35b1fc1 into validatorjs:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants