Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vrl): add documentation for parse_etld function #19795

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

esensar
Copy link
Contributor

@esensar esensar commented Feb 5, 2024

@esensar esensar requested review from a team as code owners February 5, 2024 14:16
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Feb 5, 2024
@jszwedko jszwedko requested a review from pront February 5, 2024 14:40
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @esensar !

Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We will have to wait for the next VRL release update before we can get this merged.

auto-merge was automatically disabled February 7, 2024 10:11

Head branch was pushed to by a user without write access

@pront pront self-assigned this Feb 7, 2024
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Feb 8, 2024
@jszwedko jszwedko added this pull request to the merge queue Feb 8, 2024
Copy link

github-actions bot commented Feb 9, 2024

Regression Detector Results

Run ID: eb1e6d3a-818e-4493-b4a2-5324623d2740
Baseline: 9a20a12
Comparison: 4115c65
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole egress throughput +2.32 [-0.22, +4.85]
http_elasticsearch ingress throughput +1.42 [+1.34, +1.50]
otlp_http_to_blackhole ingress throughput +0.96 [+0.80, +1.12]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.88 [+0.81, +0.95]
datadog_agent_remap_blackhole_acks ingress throughput +0.44 [+0.34, +0.54]
otlp_grpc_to_blackhole ingress throughput +0.34 [+0.25, +0.42]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +0.26 [+0.14, +0.38]
http_to_http_noack ingress throughput +0.18 [+0.09, +0.28]
syslog_splunk_hec_logs ingress throughput +0.09 [+0.01, +0.17]
http_to_s3 ingress throughput +0.05 [-0.24, +0.33]
http_to_http_json ingress throughput +0.02 [-0.06, +0.09]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.16, +0.16]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.15]
http_to_http_acks ingress throughput -0.01 [-1.31, +1.30]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.04 [-0.16, +0.07]
splunk_hec_route_s3 ingress throughput -0.09 [-0.57, +0.40]
datadog_agent_remap_blackhole ingress throughput -0.09 [-0.19, +0.02]
enterprise_http_to_http ingress throughput -0.13 [-0.22, -0.05]
socket_to_socket_blackhole ingress throughput -0.24 [-0.31, -0.17]
fluent_elasticsearch ingress throughput -0.38 [-0.84, +0.09]
syslog_log2metric_humio_metrics ingress throughput -0.43 [-0.53, -0.33]
syslog_humio_logs ingress throughput -0.50 [-0.60, -0.40]
syslog_loki ingress throughput -1.09 [-1.16, -1.03]
syslog_log2metric_splunk_hec_metrics ingress throughput -1.49 [-1.64, -1.34]
syslog_regex_logs2metric_ddmetrics ingress throughput -1.65 [-1.78, -1.52]
http_text_to_http_json ingress throughput -1.92 [-2.05, -1.79]
datadog_agent_remap_datadog_logs ingress throughput -2.39 [-2.49, -2.29]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into vectordotdev:master with commit 4115c65 Feb 9, 2024
49 checks passed
@esensar esensar deleted the docs/parse_etld branch February 9, 2024 06:03
esensar added a commit to esensar/vector that referenced this pull request Feb 9, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 9, 2024
* docs(vrl): make `parse_etld` fallible in docs

Missed in #19795

* Fix formatting for parse_etld cue file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants