Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(vrl): make parse_etld fallible in docs #19842

Merged
merged 2 commits into from
Feb 9, 2024
Merged

docs(vrl): make parse_etld fallible in docs #19842

merged 2 commits into from
Feb 9, 2024

Conversation

esensar
Copy link
Contributor

@esensar esensar commented Feb 9, 2024

Missed in #19795

@esensar esensar requested review from a team as code owners February 9, 2024 10:25
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Feb 9, 2024
jszwedko
jszwedko approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Feb 9, 2024
auto-merge was automatically disabled February 9, 2024 15:56

Head branch was pushed to by a user without write access

@esensar
Copy link
Contributor Author

esensar commented Feb 9, 2024

Good catch 👍

I realized I forgot it while I was updating punycode docs.

@jszwedko jszwedko added this pull request to the merge queue Feb 9, 2024
aliciascott
aliciascott approved these changes Feb 9, 2024
View reviewed changes
Copy link

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Merged via the queue into vectordotdev:master with commit 405f3ef Feb 9, 2024
49 checks passed
@esensar esensar deleted the docs/parse_etld_fallible branch February 9, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

@aliciascott aliciascott aliciascott approved these changes

Assignees
No one assigned
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esensar @jszwedko @aliciascott