Skip to content

Commit

Permalink
@mister-ben added dir=ltr to control bar and loading spinner. closes #…
Browse files Browse the repository at this point in the history
  • Loading branch information
mister-ben authored and gkatsev committed Mar 29, 2016
1 parent 31b2f9d commit 4cf2cc7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ CHANGELOG

## HEAD (Unreleased)
* @llun fixed menus from throwing when focused when empty ([view](https://github.com/videojs/video.js/pull/3218))
* @mister-ben added dir=ltr to control bar and loading spinner ([view](https://github.com/videojs/video.js/pull/3221))

--------------------

Expand Down
3 changes: 2 additions & 1 deletion src/js/control-bar/control-bar.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ class ControlBar extends Component {
*/
createEl() {
return super.createEl('div', {
className: 'vjs-control-bar'
className: 'vjs-control-bar',
dir: 'ltr'
}, {
'role': 'group' // The control bar is a group, so it can contain menuitems
});
Expand Down
3 changes: 2 additions & 1 deletion src/js/loading-spinner.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ class LoadingSpinner extends Component {
*/
createEl() {
return super.createEl('div', {
className: 'vjs-loading-spinner'
className: 'vjs-loading-spinner',
dir: 'ltr'
});
}
}
Expand Down

0 comments on commit 4cf2cc7

Please sign in to comment.