Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset ltr direction on control bar and spinner #3221

Closed
wants to merge 1 commit into from

Conversation

mister-ben
Copy link
Contributor

Description

If the player is inheriting rtl directionality, the control bar order reverses as flex box row order follows text direction. The loading spinner animation is also broken as the circles are not aligned. This PR resets the direction on those components to ltr, allowing the rest of the player, especially dialogs with localised text to inherit rtl.

Fixes #3204

Specific Changes proposed

Adds dir="ltr" to the ControlBar and LoadingSpinner components

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Mar 29, 2016

LGTM. Thanks @mister-ben :)

@gkatsev gkatsev added confirmed patch This PR can be added to a patch release. labels Mar 29, 2016
@gkatsev gkatsev closed this in 4cf2cc7 Mar 29, 2016
@mister-ben mister-ben deleted the hotfix/ltr branch August 10, 2016 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants