Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify minMemory definition to 1 byte. #1069

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Modify minMemory definition to 1 byte. #1069

merged 1 commit into from
Sep 27, 2020

Conversation

jiangkaihua
Copy link
Contributor

Signed-off-by: jiangkaihua jiangkaihua1@huawei.com

pr to fix #1068

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a412f3c0-ff30-11ea-b444-3dcc0bd866ab

@k82cn
Copy link
Member

k82cn commented Sep 26, 2020

@jiangkaihua , please help to fix CI :)

@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 57ae3170-0066-11eb-a257-6fde496095bb

Thor-wl
Thor-wl reviewed Sep 27, 2020
View reviewed changes
Copy link
Contributor

@Thor-wl Thor-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the CI fail points

@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 73cbb500-0091-11eb-a257-6fde496095bb

Modify minMemory definition to 1 byte.
c4abb4b 
Signed-off-by: jiangkaihua <jiangkaihua1@huawei.com>
@Thor-wl
Copy link
Contributor

Thor-wl commented Sep 27, 2020

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiangkaihua, Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2020
@volcano-sh-bot volcano-sh-bot merged commit 3843e83 into volcano-sh:master Sep 27, 2020
@jiangkaihua jiangkaihua mentioned this pull request Sep 20, 2022
Merged
@jiangkaihua jiangkaihua mentioned this pull request Dec 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thor-wl Thor-wl Thor-wl left review comments

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pods with overlarge resource requests were scheduled but kept status OutOfmemory.
5 participants
@jiangkaihua @TravisBuddy @k82cn @Thor-wl @volcano-sh-bot