Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jiangkaihua as reviewer. #2497

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

Signed-off-by: jiangkaihua <jiangkaihua1@huawei.com>
@volcano-sh-bot volcano-sh-bot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2022
@jiangkaihua jiangkaihua reopened this Sep 21, 2022
@volcano-sh-bot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are not members of the volcano-sh org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • jiangkaihua
    • OWNERS

@william-wang
Copy link
Member

@jiangkaihua Thank your for your great contribution :)

Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2022
Copy link
Member

@shinytang6 shinytang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shinytang6, william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [shinytang6,william-wang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@william-wang william-wang merged commit b1bbf93 into volcano-sh:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants