Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid as ColorIndex in src/common/InputHandler.test.ts #4614

Closed
Tyriar opened this issue Jul 27, 2023 · 0 comments · Fixed by #4618
Closed

Avoid as ColorIndex in src/common/InputHandler.test.ts #4614

Tyriar opened this issue Jul 27, 2023 · 0 comments · Fixed by #4618
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run
Milestone
5.3.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 27, 2023

Context: #4612 (comment)
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Jul 27, 2023
@Tyriar Tyriar mentioned this issue Jul 27, 2023
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 28, 2023
@Tyriar
Add IntRange type for ColorIndex
79c1fff 
Fixes xtermjs#4614
@Tyriar Tyriar mentioned this issue Jul 28, 2023
Merged
@Tyriar Tyriar added this to the 5.3.0 milestone Jul 28, 2023
@Tyriar Tyriar self-assigned this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

Add IntRange type for ColorIndex Tyriar/xterm.js
1 participant
@Tyriar