Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update typescript version to 5.1.6 #4612

Merged
merged 4 commits into from
Jul 27, 2023
Merged

update typescript version to 5.1.6 #4612

merged 4 commits into from
Jul 27, 2023

Conversation

SimonSiefke
Copy link
Contributor

required for CssStyleSheet typings needed in #4611

@@ -57,7 +57,7 @@ export class Viewport extends Disposable implements IViewport {
@ICharSizeService private readonly _charSizeService: ICharSizeService,
@IRenderService private readonly _renderService: IRenderService,
@ICoreBrowserService private readonly _coreBrowserService: ICoreBrowserService,
@IThemeService themeService: IThemeService
@IThemeService public themeService: IThemeService
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these publics added? They aren't needed as properties, only ctor args

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason ESLint was showing a warning Missing accessibility modifier on parameter property themeService, so I just added public and it kind of worked.

What do you think would be the best way to fix this?

missing-modified

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird as we explicitly say don't consider constructors:

xterm.js/.eslintrc.json

Lines 62 to 70 in b4aeb1b

"@typescript-eslint/explicit-member-accessibility": [
"warn",
{
"accessibility": "explicit",
"overrides": {
"constructors": "off"
}
}
],

We might need to update eslint, @typescript-eslint and/or that rule to be compatible with the new TS version?

Copy link
Contributor Author

@SimonSiefke SimonSiefke Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That worked! I updated eslint, @typescript-eslint/eslint-plugin and @typescript-eslint/parser to the latest version.

src/common/InputHandler.test.ts Show resolved Hide resolved
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if CI passes, thanks

@Tyriar Tyriar self-assigned this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants