Skip to content

Commit

Permalink
Update Svelte Language Server PnP Configuration (#5953)
Browse files Browse the repository at this point in the history
**What's the problem this PR addresses?**
My PR sveltejs/language-tools#2196 introduces
a small change alongside a new setting that allows
sveltejs-language-tools to resolve PnP in ESM files, most importantly in
a `svelte.config.js`. Please note that this PR shouldn't go in until
that PR is ready as otherwise the Svelte language server itself will not
have the setting available.

Also I'm no expert in Yarn PnP so if this is the wrong implementation
avenue I would welcome advice!

**How did you fix it?**
The main portion of the solution is in the linked PR. The addition here
is to set `svelte.language-server.runtime-args` to `["--loader",
"./.pnp.loader.mjs"]`.

**Checklist**
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.
  • Loading branch information
DavidArchibald committed Nov 13, 2023
1 parent f5b7abd commit 872df6d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .yarn/versions/ddf3a56f.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
releases:
"@yarnpkg/sdks": minor
1 change: 1 addition & 0 deletions packages/yarnpkg-sdks/sources/sdks/vscode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ export const generateSvelteLanguageServerWrapper: GenerateIntegrationWrapper = a
`bin/server.js` as PortablePath,
),
),
[`svelte.language-server.runtime-args`]: [`--loader`, `./.pnp.loader.mjs`],
});

await addVSCodeWorkspaceConfiguration(pnpApi, VSCodeConfiguration.extensions, {
Expand Down

0 comments on commit 872df6d

Please sign in to comment.