Update Svelte Language Server PnP Configuration #5953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2023
DavidArchibald
commented
Nov 8, 2023
| @@ -0,0 +1,2 @@ | |||
| releases: | |||
| "@yarnpkg/sdks": minor | |||
There was a problem hiding this comment.
I chose this as a minor release because yarn dlx @yarnpkg/sdks vscode theoretically has to be rerun for packages that use svelte-language-tools. This makes it feel like more than a bugfix, however it's still "backwards compatible" because this should only be needed to fix broken projects so it's not a major breaking change either.
Let me know if the versioning isn't supposed to work that way!
|
That seems good to me; as far as I can tell this shouldn't break setups for people who are currently on an old version of the Svelte extension (the setting will just be ignored, right?), so we can merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
My PR sveltejs/language-tools#2196 introduces a small change alongside a new setting that allows sveltejs-language-tools to resolve PnP in ESM files, most importantly in a
svelte.config.js. Please note that this PR shouldn't go in until that PR is ready as otherwise the Svelte language server itself will not have the setting available.Also I'm no expert in Yarn PnP so if this is the wrong implementation avenue I would welcome advice!
How did you fix it?
The main portion of the solution is in the linked PR. The addition here is to set
svelte.language-server.runtime-argsto["--loader", "./.pnp.loader.mjs"].Checklist