UCP/RNDV: Don't complete operation from CANCEL if RTS wasn't sent #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passed 4 iterations successfully. |
|
it passed 20 more iterations successfully |
brminich
approved these changes
Jan 11, 2022
|
@yosefe could you review pls? |
yosefe
reviewed
Jan 11, 2022
| @@ -422,8 +422,6 @@ void ucp_tag_rndv_cancel(ucp_request_t *sreq) | |||
| if (!(sreq->send.ep->flags & UCP_EP_FLAG_REMOTE_CONNECTED)) { | |||
| if (sreq->flags & UCP_REQUEST_FLAG_RNDV_RTS_SENT) { | |||
| ucp_rndv_req_add_to_cancelled_list(sreq, UCS_ERR_CANCELED); | |||
| } else { | |||
There was a problem hiding this comment.
when is this operation completed if rts is not sent?
is it still on pending queue in this case?
There was a problem hiding this comment.
when is this operation completed if rts is not sent?
it will be completed during pending purge
is it still on pending queue in this case?
yes, it is still in the pending queue, and it will be removed when purging
dmitrygx
force-pushed
the
topic/ucp/rndv_fix_int3
branch
from
dbe17a6
to
b11358f
Compare
yosefe
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://hpcweb.lab.mtl.com/hpc/mtr_scrap/users/mtt/scratch/ucx_ompi/20220109_125149_188193_86219_jazz02.swx.labs.mlnx/html/test_stdout_BJNZGm.txt