Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP/RNDV: Don't complete operation from CANCEL if RTS wasn't sent #233

Merged
merged 1 commit into from
Jan 11, 2022
Merged

UCP/RNDV: Don't complete operation from CANCEL if RTS wasn't sent #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ucp/tag/rndv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,10 +420,10 @@ ucs_status_t ucp_tag_send_start_rndv(ucp_request_t *sreq)
void ucp_tag_rndv_cancel(ucp_request_t *sreq)
{
if (!(sreq->send.ep->flags & UCP_EP_FLAG_REMOTE_CONNECTED)) {
/* If RTS wasn't sent, it is still on the pending queue and the request
* will be completed from the purge callback */
if (sreq->flags & UCP_REQUEST_FLAG_RNDV_RTS_SENT) {
ucp_rndv_req_add_to_cancelled_list(sreq, UCS_ERR_CANCELED);
} else {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when is this operation completed if rts is not sent?
is it still on pending queue in this case?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add code comment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when is this operation completed if rts is not sent?

it will be completed during pending purge

is it still on pending queue in this case?

yes, it is still in the pending queue, and it will be removed when purging

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add code comment

done

ucp_rndv_complete_send(sreq, UCS_ERR_CANCELED, "rndv_cancel");
}
} else {
sreq->send.uct.func = ucp_proto_progress_rndv_cancel;
Expand Down