Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell: Kernel: Reboot: echo is abruptly terminated #35325

Closed
nwsetec opened this issue May 16, 2021 · 0 comments · Fixed by #35326
Closed

Shell: Kernel: Reboot: echo is abruptly terminated #35325

nwsetec opened this issue May 16, 2021 · 0 comments · Fixed by #35326
Labels
bug The issue is a bug, or the PR is fixing a bug

Comments

@nwsetec
Copy link
Contributor

nwsetec commented May 16, 2021

Describe the bug
When the kernel reboot cold or kernel reboot warm command is input quickly (by a production test system) the kernel reboot command's echo is abruptly terminated 10% of the time by the system's reset.

To Reproduce
Steps to reproduce the behavior:

  1. Add line CONFIG_REBOOT=y to samples\subsys\shell\shell_module\prj.conf
  2. west build -p -b nrf52dk_nrf52832 -s samples\subsys\shell\shell_module -d build
  3. Input the kernel reboot cold or kernel reboot warm command at or near to max baud rate.

Expected behavior
Kernel reboot command's echo completes successfully every time.

Impact
Our production line test fails 10% of the time when using this command.
@nwsetec nwsetec added the bug The issue is a bug, or the PR is fixing a bug label May 16, 2021
@nwsetec nwsetec mentioned this issue May 17, 2021
Merged
nwsetec added a commit to nwsetec/zephyr that referenced this issue May 17, 2021
@nwsetec
shell: kernel: fix reset command echo abrupt termination
5ea8d44 
Allow time for the shell to successfully echo the reboot command input
before the reboot abruptly terminates it. n This can help external
systems that interact with the shell and require the reboot command's
echo to successfully complete to synchronise with the device.

Fixes: zephyrproject-rtos#35325

Signed-off-by: Nick Ward <nick.ward@setec.com.au>
galak pushed a commit that referenced this issue May 18, 2021
@nwsetec @galak
shell: kernel: fix reset command echo abrupt termination
3cad7f3 
Allow time for the shell to successfully echo the reboot command input
before the reboot abruptly terminates it. n This can help external
systems that interact with the shell and require the reboot command's
echo to successfully complete to synchronise with the device.

Fixes: #35325

Signed-off-by: Nick Ward <nick.ward@setec.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

shell: kernel: fix reset command echo abrupt termination nwsetec/zephyr
1 participant
@nwsetec