shell: kernel: fix reset command echo abrupt termination #35326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow time for the shell to successfully echo the reboot command input before the reboot abruptly terminates it. n This can help external systems that interact with the shell and require the reboot command's echo to successfully complete to synchronise with the device. Fixes: zephyrproject-rtos#35325 Signed-off-by: Nick Ward <nick.ward@setec.com.au>
nwsetec
force-pushed
the
fix_reset_shell_cmd
branch
from
dee19e4
to
5ea8d44
Compare
jakub-uC
reviewed
May 17, 2021
| @@ -220,6 +220,9 @@ static int cmd_kernel_reboot_warm(const struct shell *shell, | |||
| { | |||
| ARG_UNUSED(argc); | |||
| ARG_UNUSED(argv); | |||
| #if (CONFIG_KERNEL_SHELL_REBOOT_DELAY > 0) | |||
There was a problem hiding this comment.
To be considered if IS_ENABLED is better. @nordic-krch any thoughts?
There was a problem hiding this comment.
IS_ENABLED cannot be used because it is not binary value you might do
if (CONFIG_KERNEL_SHELL_REBOOT_DELAY > 0) {
k_sleep();
}
but compilation will fail when CONFIG_REBOOT is not defined. So i guess it should stay as is.
nordic-krch
approved these changes
May 18, 2021
jakub-uC
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow time for the shell to successfully echo the reboot command input
before the reboot abruptly terminates it. This can help external
systems that interact with the shell and require the reboot command's
echo to successfully complete to synchronise with the device.
Fixes: #35325
Signed-off-by: Nick Ward nick.ward@setec.com.au