Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: emu: nsim: fix nsim props and args name #38020

Merged
merged 1 commit into from
Sep 7, 2021
Merged

cmake: emu: nsim: fix nsim props and args name #38020

merged 1 commit into from
Sep 7, 2021

Conversation

wangnuannuan
Copy link
Collaborator

use this change to fix #38019

nsim_sem_mpu_stack_guard board use nism_sem board's config file

Signed-off-by: Jingru Wang jingru@synopsys.com

@zephyrbot zephyrbot requested a review from IRISZZW August 26, 2021 14:15
@ruuddw
Copy link
Member

ruuddw commented Aug 30, 2021

Isn't it simpler to create 'nsim_sem_mpu_stack_guard.[args|props] files instead of the extra cmake code for handling this?

evgeniy-paltsev
evgeniy-paltsev requested changes Aug 31, 2021
View reviewed changes
Copy link
Collaborator

@evgeniy-paltsev evgeniy-paltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also propose to just create required args\props files instead of increasing complexity of board.cmake and introducing the implicit cross-dependency.

@evgeniy-paltsev evgeniy-paltsev added the area: ARC ARC Architecture label Aug 31, 2021
@wangnuannuan wangnuannuan force-pushed the jingru-fix-38019 branch 2 times, most recently from faa6ac8 to 9b6f16b Compare September 1, 2021 02:17
@evgeniy-paltsev
Copy link
Collaborator

Hmm, is the commit message still actual?

Before nsim_sem_mpu_stack_guard board uses nism_sem board's config files, so we had to use the extra cmake code for handling it.

We don't do workarounds in cmake code now (the only change in cmake is just a cleanup as I can see)

@wangnuannuan
ARC: add config files for nsim_sem_mpu_stack_guard
a40ab40 
Add nsim_sem_mpu_stack_guard.props and
nsim_sem_mpu_stack_guard.args, so we don't
do workarounds in cmake code.

Signed-off-by: Jingru Wang <jingru@synopsys.com>
@nashif nashif merged commit 86f1bdc into zephyrproject-rtos:main Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruuddw ruuddw ruuddw approved these changes

@evgeniy-paltsev evgeniy-paltsev evgeniy-paltsev approved these changes

@abrodkin abrodkin Awaiting requested review from abrodkin

@IRISZZW IRISZZW Awaiting requested review from IRISZZW

Assignees

@wangnuannuan wangnuannuan

Labels
area: ARC ARC Architecture area: Boards platform: Synopsys Synopsys
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nsim_sem_mpu_stack_guard board can't run
5 participants
@wangnuannuan @ruuddw @evgeniy-paltsev @nashif @zephyrbot