Autogrow textarea fixes #2899

nantunes · 2015-05-19T00:48:07Z

Several changes I needed for a project.

One is a bug fix, the others are small new features, so it probably don't fulfill the pre-1.0 contribution guidelines. But I share it, maybe the patches are useful for someone else.

…and possibly others)

…2006)

nantunes · 2015-05-19T01:23:15Z

src/components/input/input.js

-      element.on('scroll', onScroll);
+
+      if(isNaN(min_rows)) {
+        element.on('scroll', onScroll);


Don't really understand what onScroll does... Hence the if block.

Added in 545582d

…red order

Related to #3101

Closes #852

closes #3197

closes #3205

closes #3204, references #3218

closes #3189

closes #3217

Closes #2973

closes #3128

and md-tab-body Closes #3206

Closes #3198

…ght` Closes #3184

Remove check for pointer-events not equal to none to resolve non-visible tooltips on Firefox. Add Chrome & Firefox as default test runners in karma task to avoid regressions like this in the future. Improve and automate use of ngAnimateMock Fixes #3047. Fixes #3250. Fixes #3430. Closes #3467.

Closes #3536.

update docs. Closes #3391. Closes #3534.

…`md-selected` is added to `md-tabs` Closes #3537

…r simplicity's sake

Fixes #3423. Closes #3451.

Fixes #3240. Closes #3427.

Closes #3396.

Closes #3238.

Change min-height for textarea to one line height (and remove extra padding space), and set rows=“1”, since it defaults to 2. Closes #2953. Fixes #2154.

ThomasBurleson · 2015-07-01T22:21:24Z

src/components/input/input.scss

@@ -138,6 +138,10 @@ md-input-container {
      outline: none;
      box-shadow: none;
    }
+
+    &.md-no-flex {
+      flex: none !important;


We try to avoid !important overrides. Is this the only solution?

I don't really love this solution, as md-no-flex is an "utility" class. But I had no success defining temporarily the 'flex: none' on the element directly (where it would take precedence over all the other rules).

Do you have any suggestions?

ThomasBurleson · 2015-07-01T22:22:19Z

@nantunes
Please rebase with master and changes that include 52ca5e5.
Retest and determine if this PR is still valid and necessary.

Closes #3385.

Closes #2566.

…and possibly others)

…2006)

…into autogrow-textarea-fix * 'autogrow-textarea-fix' of github.com:nantunes/material: Adds support for textarea auto grow based on rows attribute (resolves #2006) Fixes textarea auto grow inside scrollable container (resolves #2007 and possibly others) Makes textarea autogrow optional, resolves #1209

googlebot · 2015-07-01T23:00:57Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

nantunes · 2015-07-01T23:37:11Z

(Did I screw up with the rebase?)

I think the PR is still valid, as the abilities to specify the textarea height with the "rows" attribute and to disable autogrow don't yet exist on master. I need these features in my project, but they're not critical so I leave it to your criterium.

Also the 2665203 still fixes #2007.

ThomasBurleson · 2015-07-01T23:39:45Z

@nantunes - You will need to squash this PR or submit a new one with a single commit.

I would say this PR is corrupted with your latest changes.

nantunes · 2015-07-01T23:57:26Z

Yep, sorry about that. Maybe it was that unintended merge commit.

I've opened #3544.

nantunes added 3 commits May 19, 2015 00:56

Makes textarea autogrow optional, resolves #1209

dc30314

Fixes textarea auto grow inside scrollable container (resolves #2007 …

2665203

…and possibly others)

Adds support for textarea auto grow based on rows attribute (resolves #…

97e91aa

…2006)

nantunes reviewed May 19, 2015
View reviewed changes

Robert Messerle and others added 26 commits June 9, 2015 16:54

update(build): fixes dry-run logic

eced631

update(docs): adds label overrides for FAB Speed Dial and FAB Toolbar

4c1745f

feat(fabToolbar): adds fabToolbar component

30a53c3

Added in 545582d

feat(fabSpeedDial): adds fabSpeedDial component

e813dcd

Added in 545582d

update(build): switches to conventional changelog fork with our prefe…

c985880

…red order

release: version 0.10.0-rc2

d765bdc

update version number in package.json to 0.10.0-rc2

289274d

update(docs): rolls back to AngularJS 1.3.15

c4e0196

chore(tabs): refactors to remove link function from tabsDirective

c9d25dd

chore(changelog): fixes changelog in master

fca1d5b

chore(changelog): pulled correct changelog from v0.10.0-rc1

d0b385d

fix(tabs): fixes infinite digests bug in Firefox

781929d

Related to #3101

fix(checkbox): adds ability to click links within checkbox

999e0da

Closes #852

fix(mdMenu): fix rc2 complete break

fb245fb

closes #3197

fix(mdMenu): re-enable keyboard controls

2513153

closes #3205

fix(mdMenu): fix positioning breaking after scroll/resize

94b03b0

closes #3204, references #3218

fix(mdMenu): close on scope $destroy

67be5ce

closes #3189

feat(select): add mdOnClose expression eval event

d7bfc86

closes #3217

fix(mdMenu): improve aria accessability

113ad44

update(util): makes the method for locking scrolling more generic

33c3397

fix(autocomplete): locks scrolling while autocomplete menu is visible

deae957

Closes #2973

fix(select): fix focus color not picking up theming

781a4bc

closes #3128

update(util): fixes scroll lock logic introduced in previous commit

83a50f2

fix(tabs): nested tabs should now work properly when using md-tab-label

e3e52c2

and md-tab-body Closes #3206

fix(tabs): fixes centered tabs for Safari

2552686

Closes #3198

fix(tabs): fixes CSS to respect non-truthy values for `md-dynamic-hei…

6019718

…ght` Closes #3184

Robert Messerle and others added 11 commits June 30, 2015 14:41

update(build): replaces url with origin for now

ee60441

feat(virtualRepeat): Add md-auto-shrink and md-auto-shrink-min

79dcbf7

Closes #3536.

update(virtualRepeat): Make md-item-size optional

c164ef0

update docs. Closes #3391. Closes #3534.

fix(tabs): prevents an error from being thrown if an empty attribute …

f5cd5a0

…`md-selected` is added to `md-tabs` Closes #3537

update(tabs): rolls back manual two-way binding of 'selectedIndex' fo…

a161013

…r simplicity's sake

fix($mdConstant): fix overlapping in media-queries

61a0e53

Fixes #3423. Closes #3451.

update(fabSpeedDial): fix positioning for mixed button sizes

caf6977

Fixes #3240. Closes #3427.

refactor(gulpfile): use forEach instead of filter

0fbe335

Closes #3396.

upate(icon): Allow chaining on $mdIconProvider.fontSet() method

59c7335

Closes #3238.

fix(textarea): Start at a height of one line

52ca5e5

Change min-height for textarea to one line height (and remove extra padding space), and set rows=“1”, since it defaults to 2. Closes #2953. Fixes #2154.

ThomasBurleson reviewed Jul 1, 2015
View reviewed changes

ThomasBurleson added the wip label Jul 1, 2015

Robert Messerle and others added 2 commits July 1, 2015 15:34

update(docs): rolls back to Angular v1.3.15 until v1.4.2 is released

3062df0

feature(build): add concatenated SCSS file for distribution

720ed90

Closes #3385.

ThomasBurleson modified the milestone: 0.11.0 Jul 1, 2015

tkrotoff and others added 5 commits July 1, 2015 17:57

chore(): simplify .gitignore

b7146dc

Closes #2566.

Makes textarea autogrow optional, resolves #1209

4c6de14

Fixes textarea auto grow inside scrollable container (resolves #2007 …

9363a13

…and possibly others)

Adds support for textarea auto grow based on rows attribute (resolves #…

c986e7b

…2006)

Avoid "rows" attribute unintended overwrite by default value

9d81e07

nantunes mentioned this pull request Jul 1, 2015

Adds support for textarea's "rows" attribute and makes autogrow optional #3544

Closed

nantunes closed this Jul 1, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autogrow textarea fixes #2899

Autogrow textarea fixes #2899

nantunes commented May 19, 2015

nantunes May 19, 2015

ThomasBurleson Jul 1, 2015

nantunes Jul 1, 2015

ThomasBurleson commented Jul 1, 2015

googlebot commented Jul 1, 2015

nantunes commented Jul 1, 2015

ThomasBurleson commented Jul 1, 2015

nantunes commented Jul 1, 2015

Autogrow textarea fixes #2899

Autogrow textarea fixes #2899

Conversation

nantunes commented May 19, 2015

nantunes May 19, 2015

Choose a reason for hiding this comment

ThomasBurleson Jul 1, 2015

Choose a reason for hiding this comment

nantunes Jul 1, 2015

Choose a reason for hiding this comment

ThomasBurleson commented Jul 1, 2015

googlebot commented Jul 1, 2015

nantunes commented Jul 1, 2015

ThomasBurleson commented Jul 1, 2015

nantunes commented Jul 1, 2015