Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/tx): concurrent map writes when calling GetSigners #21073

Merged
merged 9 commits into from
Jul 31, 2024

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Jul 25, 2024

Description

Whenever GetSigners is called and the getSignerFn hasn't been set for the message type, it will set it on an internal map. If this is called in 2 or more places at the same time it will cause a concurrent map write issue.

To avoid this, developers must call interfaceRegistry.SigningContext().Validate() when creating the app (depinject users don't need this as it's being done when providing the interfaceRegistry).

Also, a write only mutex has been added as a defensive measure in case there's any unhandled case (most likely because of a misconfiguration, or usage of multiple instances of SigningContexts). This shouldn't add any overhead to well configured binaries, and little to misconfigured ones.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced a validation step during context initialization to enhance robustness and error handling.
    • Improved the method for retrieving signer functions to utilize thread-safe access for better reliability.
    • Added new tests to ensure concurrency behavior of signer function retrieval.
  • Bug Fixes

    • Resolved potential data corruption issues by safeguarding access to the signers' function map with concurrency controls.
  • Documentation

    • Updated the changelog for the x/tx module to reflect recent improvements and enhancements.

@facundomedica facundomedica requested a review from a team as a code owner July 25, 2024 14:31
Copy link
Contributor

coderabbitai bot commented Jul 25, 2024

Walkthrough

Walkthrough

The recent changes enhance the robustness and thread safety of the application. A new validation step in the NewSimApp function ensures the integrity of the SigningContext. Additionally, a sync.Map and a write-only mutex have been introduced in the Context struct to prevent concurrent write access issues in the getSignersFuncs map. Further improvements include validation logic in the NewContext function and the addition of concurrency tests for signing functions.

Changes

File(s) Change Summary
simapp/app.go Added validation for SigningContext in the NewSimApp function, enhancing initialization robustness.
x/tx/CHANGELOG.md Updated changelog to include improvements related to mutex implementation for thread safety.
x/tx/signing/context.go Introduced a sync.Map in the Context struct to safeguard the getSignersFuncs map from concurrent access. Modified getGetSignersFn method for thread-safe operation.
x/tx/signing/context_test.go Added TestGetGetSignersFnConcurrent to test concurrency behavior of getGetSignersFn method.

Sequence Diagram(s)

sequenceDiagram
    participant App as SimApp
    participant Context as SigningContext
    
    App->>Context: Initialize SigningContext
    alt Validation Check
        Context->>App: Valid SigningContext
    else Validation Fails
        App->>App: Panic (Critical Error)
    end
Loading
sequenceDiagram
    participant Context as Context
    participant Signers as GetSignersFuncs

    Context->>Signers: Lock Mutex
    Signers->>Context: Access Functions
    Context->>Signers: Unlock Mutex
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This comment has been minimized.

@facundomedica facundomedica added backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release and removed C:x/tx labels Jul 25, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 683371f and 33348e7.

Files selected for processing (3)
  • simapp/app.go (1 hunks)
  • x/tx/CHANGELOG.md (1 hunks)
  • x/tx/signing/context.go (4 hunks)
Additional context used
Path-based instructions (3)
x/tx/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

x/tx/signing/context.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

simapp/app.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (6)
x/tx/CHANGELOG.md (1)

36-38: Changelog entry looks good!

The changelog entry is correctly formatted and provides a clear description of the improvement.

x/tx/signing/context.go (4)

6-6: Import statement looks good!

The import of the sync package is necessary for the mutex implementation.


35-37: Context struct changes look good!

The addition of the mtx field of type sync.Mutex is appropriate for enhancing thread safety.


116-116: NewContext function changes look good!

The initialization of the mtx field in the NewContext function is correct and necessary.


343-344: Mutex locking in getGetSignersFn looks good!

The addition of c.mtx.Lock() and defer c.mtx.Unlock() ensures thread safety for the getSignersFuncs map.

simapp/app.go (1)

606-610: SigningContext validation in NewSimApp looks good!

The addition of the validation step for SigningContext ensures that the internal signers' functions map is correctly pre-filled and any issues are caught early.

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you @facundomedica.

I think in future I'd be favour of moving the current Validate() logic (greedy startup approach) in NewContext() rather than in the validation func itself.

That, or change the return on L122 to be the following, since NewContext already has an error return:

return c, c.Validate()

Maybe I'm missing something but I'm not sure I see the use case for creating getSignersFunc at runtime/on the fly

Copy link
Member

@kocubinski kocubinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -336,6 +340,8 @@ func (c *Context) getGetSignersFn(messageDescriptor protoreflect.MessageDescript
}
f, ok = c.getSignersFuncs[messageDescriptor.FullName()]
if !ok {
c.mtx.Lock()
defer c.mtx.Unlock()
var err error
f, err = c.makeGetSignersFunc(messageDescriptor)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm because makeGetSignersFunc is stateless right? so worst case we get multiple blocked writes which will quickly resolve

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, before the worst case would bring the node down, now the worst case just creates some tiny delays

@facundomedica
Copy link
Member Author

Nice! Thank you @facundomedica.

I think in future I'd be favour of moving the current Validate() logic (greedy startup approach) in NewContext() rather than in the validation func itself.

That, or change the return on L122 to be the following, since NewContext already has an error return:

return c, c.Validate()

Maybe I'm missing something but I'm not sure I see the use case for creating getSignersFunc at runtime/on the fly

I think we can't do this as there are going to be other messages being registered later. Maybe every time we register a new message we call the getSignersFunc? 🤔

Copy link
Member

@kocubinski kocubinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I took a deeper look at the golang map spec; even with a single writer and single concurrent reader this is still a panic vector.

https://go.dev/play/p/ws2BvhfI3-p

@kocubinski
Copy link
Member

2 options I see:

  1. commit to sync.Map
  2. return err if signer func not found with a nag msg like "hey did you run Validate()" ?.

I think (2) is OK, protoc generated types register their file descriptors in init() which runs before main(), so we can expect any type which has been imported will be ranged over.

@kocubinski
Copy link
Member

return c, c.Validate()

Maybe I'm missing something but I'm not sure I see the use case for creating getSignersFunc at runtime/on the fly

IIRC we were worried about runtime overhead of map building and memory usage but that doesn't seem to carry much weight, I like this solution

@julienrbrt
Copy link
Member

I'll hold off tagging v0.50.9 until this is resolved.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 33348e7 and 8f8322d.

Files selected for processing (1)
  • x/tx/signing/context.go (4 hunks)
Additional context used
Path-based instructions (1)
x/tx/signing/context.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (4)
x/tx/signing/context.go (4)

118-120: LGTM! Validation step enhances robustness.

The inclusion of the validation step ensures that the context is properly configured before use, enhancing the robustness of the code.


168-168: LGTM! Validation logic is sound.

The validation logic checks for errors in message signers and pre-populates the internal cache, improving performance and error handling.


336-348: LGTM! Improved error handling with add parameter.

The introduction of the add parameter enhances error handling by preventing the creation of new signer functions if validation has not been called.


360-362: LGTM! Adheres to new validation logic.

The update ensures that the GetSigners function adheres to the new validation logic, preventing the creation of new signer functions if validation has not been called.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
x/tx/signing/context_test.go (1)

54-79: Good concurrency test, but add validation checks.

The function effectively tests concurrent access to getGetSignersFn. However, uncommenting the validation checks would ensure the correctness of the results.

-	// err = ctx.Validate()
-	// require.NoError(t, err)
+	err = ctx.Validate()
+	require.NoError(t, err)

-	// signers, err := fn(msg)
-	// require.NoError(t, err)
-	// require.Equal(t, [][]byte{[]byte("foo")}, signers)
+	fn, err := ctx.getGetSignersFn(desc)
+	require.NoError(t, err)
+	signers, err := fn(msg)
+	require.NoError(t, err)
+	require.Equal(t, [][]byte{[]byte("foo")}, signers)
Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8f8322d and 4f31098.

Files selected for processing (2)
  • x/tx/signing/context.go (1 hunks)
  • x/tx/signing/context_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • x/tx/signing/context.go
Additional context used
Path-based instructions (1)
x/tx/signing/context_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.


Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

Additional comments not posted (3)
x/tx/signing/context_test.go (3)

Line range hint 80-153:
Comprehensive test coverage for GetSigners.

The function thoroughly tests various message types for the GetSigners method.


Line range hint 155-174:
Effective test for maximum recursion depth.

The function effectively tests the recursion depth limits for the GetSigners method.


Line range hint 176-211:
Comprehensive test for custom signer definitions.

The function thoroughly tests various scenarios for custom signer definitions in the GetSigners method.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4f31098 and c077988.

Files selected for processing (3)
  • x/tx/CHANGELOG.md (1 hunks)
  • x/tx/signing/context.go (4 hunks)
  • x/tx/signing/context_test.go (2 hunks)
Files skipped from review as they are similar to previous changes (2)
  • x/tx/CHANGELOG.md
  • x/tx/signing/context_test.go
Additional context used
Path-based instructions (1)
x/tx/signing/context.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (5)
x/tx/signing/context.go (5)

33-33: Improved thread safety with sync.Map.

The use of sync.Map for getSignersFuncs enhances thread safety by allowing concurrent access, which is appropriate for resolving concurrent map write issues.


119-121: Validation step added to NewContext.

Adding the call to c.Validate() ensures that the context is properly configured before it is returned, which helps maintain the integrity of the context.


343-352: Thread-safe access to getSignersFuncs with sync.Map.

The use of sync.Map and its methods (Load and Store) in getGetSignersFn ensures thread-safe access to the getSignersFuncs map, preventing concurrent map write issues.


Line range hint 356-356:
Alignment with validation logic in GetSigners.

Passing false as the add argument when invoking getGetSignersFn aligns the method with the new validation logic, ensuring consistency and correctness.


Line range hint 147-181:
Comprehensive validation in Validate.

The Validate method performs a dry run of getting all message signers to pre-populate the internal cache and catch configuration errors early, which is beneficial for maintaining the integrity of the context.

@julienrbrt julienrbrt removed backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release labels Jul 31, 2024
@julienrbrt
Copy link
Member

julienrbrt commented Jul 31, 2024

I'll hold off tagging v0.50.9 until this is resolved.

I see now it is only touching x/tx. So no need to backport anything. I'll check if the last tagged version of x/tx corresponds to what x/tx main is. And do some branching if not to release this.

@julienrbrt julienrbrt changed the title fix: concurrent map writes when calling GetSigners fix(x/tx): concurrent map writes when calling GetSigners Jul 31, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@facundomedica
Copy link
Member Author

I think I'll have to remove the Validate when we create it as there is one instance in which we create a new interface registry and we don't pass the custom signers func and fails (see the integration test)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c077988 and 313f9eb.

Files selected for processing (2)
  • simapp/app.go (1 hunks)
  • x/tx/signing/context.go (4 hunks)
Files skipped from review as they are similar to previous changes (2)
  • simapp/app.go
  • x/tx/signing/context.go

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 313f9eb and a042f81.

Files selected for processing (1)
  • x/tx/signing/context_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • x/tx/signing/context_test.go

@facundomedica facundomedica added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit de0708b Jul 31, 2024
77 checks passed
@facundomedica facundomedica deleted the facu/fix-getsigfn-conc branch July 31, 2024 15:19
@facundomedica facundomedica added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Jul 31, 2024
mergify bot pushed a commit that referenced this pull request Jul 31, 2024
@coderabbitai coderabbitai bot mentioned this pull request Jul 31, 2024
12 tasks
@facundomedica facundomedica added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 31, 2024
mergify bot pushed a commit that referenced this pull request Jul 31, 2024
(cherry picked from commit de0708b)

# Conflicts:
#	x/tx/CHANGELOG.md
#	x/tx/signing/context_test.go
julienrbrt added a commit that referenced this pull request Jul 31, 2024
…21073) (#21126)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Facundo <facundomedica@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@julienrbrt julienrbrt mentioned this pull request Aug 1, 2024
12 tasks
julienrbrt added a commit that referenced this pull request Aug 1, 2024
…21073) (#21130)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Facundo <facundomedica@gmail.com>
@julienrbrt julienrbrt mentioned this pull request Aug 2, 2024
12 tasks
mmsqe added a commit to crypto-org-chain/cosmos-sdk that referenced this pull request Sep 30, 2024
* build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844)

Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859)

Co-authored-by: Kien <kien@notional.ventures>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* reuse fromAddrString (minor cleanup) (cosmos#19881)

* feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887)

* feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* docs(x/mint): Fix inconsistency in mint docs  (backport cosmos#19915) (cosmos#19925)

* build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008)

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017)

Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029)

Co-authored-by: mmsqe <mavis@crypto.com>

* fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>

* fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046)

Co-authored-by: mmsqe <mavis@crypto.com>

* build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024)

* fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050)

* fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>

* build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095)

* feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: prepare v0.50.6 (cosmos#19998)

* fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111)

Co-authored-by: mmsqe <mavis@crypto.com>

* fix(x/authz,x/feegrant): check blocked address (cosmos#20102)

* chore: update v0.50.6 release notes (cosmos#20124)

* build(deps): bump sdk in modules (cosmos#20126)

* docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131)

Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com>

* fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* docs: fix broken link (backport cosmos#20133) (cosmos#20138)

* build(deps): bump modules in simapp (cosmos#20137)

* build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152)

* docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155)

Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com>

* fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185)

Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251)

Co-authored-by: Marko <marko@baricevic.me>

* feat(baseapp): expose grpc query router via depinject. (cosmos#20264)

* feat(client/v2): override short description in generated command (backport cosmos#20266) (cosmos#20269)

Co-authored-by: John Letey <j@letey.de>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(runtime): Add missing NewTransientStoreService (backport cosmos#20261) (cosmos#20327)

Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com>

* fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323) (cosmos#20329)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* fix(client/v2): correctly check subcommand short descriptions (backport cosmos#20330) (cosmos#20340)

* build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338)

* style: Fix gov query proposals examples syntax (backport cosmos#20353) (cosmos#20357)

* feat(client): add consensus address for debug cmd (backport cosmos#20328) (cosmos#20366)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(client): overwrite client context instead of setting new one (backport cosmos#20356) (cosmos#20383)

Co-authored-by: Shude Li <islishude@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: correctly assign `execModeSimulate` to context for `simulateTx` (backport cosmos#20342) (cosmos#20346)

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* docs: update diagram to be shown properly (backport cosmos#20454) (cosmos#20460)

Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* docs: fix note blocks display failure (backport cosmos#20457) (cosmos#20459)

Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com>

* docs: update link contents (backport cosmos#20437) (cosmos#20462)

Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com>

* fix(x/consensus): harden consensus params proposal (cosmos#20381)

Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>

* docs: add docs on permissions (backport cosmos#20526) (cosmos#20527)

Co-authored-by: Marko <marko@baricevic.me>

* chore(x/upgrade): bump vulnerable `go-getter` library (cosmos#20530)

* chore: prepare v0.50.7 (cosmos#20475)

* build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590)

* docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627)

Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660)

Co-authored-by: Daniel Wedul <github@wedul.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711)

* feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712)

Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Facundo <facundomedica@gmail.com>

* feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751)

* feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897)

Co-authored-by: Chenqun Lu <luchenqun@qq.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909)

Co-authored-by: Chenqun Lu <luchenqun@qq.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: prepare v0.50.8 (cosmos#20910)

* chore(simapp): use tagged version (cosmos#20951)

* fix: include pagination.key at reverse mode (backport cosmos#20939) (cosmos#20954)

Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com>
Co-authored-by: Facundo <facundomedica@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.9 to 0.38.10 (cosmos#20960)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(client/v2): use (PREFIX)_HOME instead of NODE_HOME (backport cosmos#20964) (cosmos#20970)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(client/grpc): `node.NewQueryServer` method not setting `cfg` (backport cosmos#20969) (cosmos#20973)

* fix: NewIntegrationApp does not write default genesis to state (backport cosmos#21006) (cosmos#21008)

Co-authored-by: son trinh <trinhleson2000@gmail.com>

* fix(crypto): revert cosmos#20438 (cosmos#21019)

* feat: use depinject v1.0.0 (cosmos#21000)

* fix(runtime): remove `appv1alpha1.Config` from runtime (backport cosmos#21042) (cosmos#21080)

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* feat: check latest block if no arg in `q block` and `q block-results` (backport cosmos#21084) (cosmos#21111)

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>

* fix(simapp): concurrent map writes when calling GetSigners (backport cosmos#21073) (cosmos#21130)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Facundo <facundomedica@gmail.com>

* docs: Fix cli usage examples (backport cosmos#21150) (cosmos#21154)

Co-authored-by: Christoph Otter <chipshort@tutanota.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: bring in v0.13.x x/tx in release/v0.50.x (cosmos#21158)

* build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (cosmos#21170)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(baseapp): return events from preblocker in FinalizeBlockResponse (backport cosmos#21159) (cosmos#21162)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Facundo <facundomedica@gmail.com>

* chore: prepare v0.50.9 (cosmos#21163)

* ci: attempt to fix goreleaser (backport cosmos#21194) (cosmos#21196)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* build(deps): Bump cosmossdk.io/log from 1.3.1 to 1.4.0 (cosmos#21209)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* chore: backport NewMemStoreService method (cosmos#21212)

* build(deps): Bump github.com/cosmos/gogoproto from 1.5.0 to 1.6.0 (cosmos#21234)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* feat: module hash by height query (backport cosmos#20779) (cosmos#21247)

Co-authored-by: Adam Tucker <adam@osmosis.team>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.10 to 0.38.11 (cosmos#21264)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* feat(confix): allow customization of migration plan (backport cosmos#21202) (cosmos#21268)

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* build(deps): Bump github.com/cosmos/gogoproto from 1.6.0 to 1.7.0 (cosmos#21294)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(baseapp)!: Halt at height now does not produce the halt height block (backport cosmos#21256) (cosmos#21323)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Facundo <facundomedica@gmail.com>

* chore: bring in core v0.11.x (v0.50 compatible) to v0.50 (cosmos#21298)

* docs: rename app v2 to app di when talking about runtime v0 (backport cosmos#21329) (cosmos#21335)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* build(deps): Bump cosmossdk.io/log from 1.4.0 to 1.4.1 (cosmos#21351)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* docs: fix outdated link (backport cosmos#21397) (cosmos#21400)

Co-authored-by: KI <KIVIKY@protonmail.com>

* feat(x/bank): add origin address in event multisend (backport cosmos#21460) (cosmos#21465)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* build(deps): Bump github.com/cosmos/ics23/go from 0.10.0 to 0.11.0 (cosmos#21473)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(baseapp): preblock events are not emmitted correctly (backport cosmos#21444) (cosmos#21458)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(x/consensus)!: update cons params parsing checks (backport cosmos#21484) (cosmos#21493)

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(types/mempool): fix slice init length (backport cosmos#21494) (cosmos#21519)

Co-authored-by: dropbigfish <fillfish@foxmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.11 to 0.38.12 (cosmos#21535)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(x/genutil): bulk add genesis accounts (backport cosmos#21372) (cosmos#21544)

Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com>
Co-authored-by: Reece Williams <reecepbcups@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(mempool): data race in mempool prepare proposal handler (backport cosmos#21413) (cosmos#21541)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* build(deps): bump iavl in cosmossdk.io/store 1.1.x (cosmos#21574)

* docs(x/evidence): fix evidence module subcommands help message (backport cosmos#21589) (cosmos#21592)

* docs(client/debug): correct and improve  `debug pubkey-raw` command example (backport cosmos#21594) (cosmos#21600)

Co-authored-by: lilasxie <thanklilas@163.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* docs(client/debug): correct `debug raw-bytes` command example (backport cosmos#21671) (cosmos#21676)

Co-authored-by: lilasxie <thanklilas@163.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* docs(x/authz): update grant docs (backport cosmos#21677) (cosmos#21700)

Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com>
Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com>

* feat(x/genutil): add better error messages for genesis validation (backport cosmos#21701) (cosmos#21708)

Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* feat(types/collections): add `LegacyDec` collection value (backport cosmos#21693) (cosmos#21724)

Co-authored-by: John Letey <john@noble.xyz>
Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>

* docs: demonstrate how to wire custom ante handlers in 0.50 app_di (cosmos#21767)

* docs(x/circuit): display correct example (backport cosmos#21768) (cosmos#21773)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(runtime): fix option order (backport cosmos#21769) (cosmos#21771)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: prepare v0.50.10 (cosmos#21498)

* feat(x/tx): add `aminoNameAsTypeURL` option in aminojson encoder (backport cosmos#21712) (cosmos#21798)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(client/v2): use x/tx `AminoNameAsTypeURL` option in 0.50 (cosmos#21801)

* feat(testutil/integration): allow to pass baseapp options (backport cosmos#21816) (cosmos#21818)

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* chore: correct date cl v0.50.10 (cosmos#21832)

* feat(crypto/keyring): add Linux's keyctl support (backport cosmos#21653) (cosmos#21840)

Co-authored-by: Alessio Treglia <al@essio.dev>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(x/staking): query redelegation command (backport cosmos#21856) (cosmos#21861)

Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore(docs): rename merlin to simapp (backport cosmos#21884) (cosmos#21886)

Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* fix(cli): avoid id isn't supported error when query address-by-acc-num (backport cosmos#21919) (cosmos#21922)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(sims): Skip sims test when running dry on validators (backport cosmos#21906) (cosmos#21910)

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix(client/v2): correctly handle enhanced sub commands (backport cosmos#21809) (cosmos#21930)

Co-authored-by: John Letey <john@noble.xyz>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(client/v2): improve error message on enums (backport cosmos#21936) (cosmos#21938)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: regenerate addrbook.json for in-place-testnet (backport cosmos#21941) (cosmos#21947)

Co-authored-by: Adam Tucker <adam@osmosis.team>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* align thresholdStringEncoder

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Kien <kien@notional.ventures>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com>
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com>
Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com>
Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com>
Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: John Letey <j@letey.de>
Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com>
Co-authored-by: Shude Li <islishude@gmail.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com>
Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com>
Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Daniel Wedul <github@wedul.com>
Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com>
Co-authored-by: Facundo <facundomedica@gmail.com>
Co-authored-by: Chenqun Lu <luchenqun@qq.com>
Co-authored-by: Christoph Otter <chipshort@tutanota.com>
Co-authored-by: Adam Tucker <adam@osmosis.team>
Co-authored-by: KI <KIVIKY@protonmail.com>
Co-authored-by: MSalopek <matija.salopek994@gmail.com>
Co-authored-by: dropbigfish <fillfish@foxmail.com>
Co-authored-by: Reece Williams <reecepbcups@gmail.com>
Co-authored-by: lilasxie <thanklilas@163.com>
Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com>
Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com>
Co-authored-by: John Letey <john@noble.xyz>
Co-authored-by: Alessio Treglia <al@essio.dev>
Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release C:x/tx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants