fix(cli): avoid id isn't supported error when query address-by-acc-num

[mmsqe]

for more info,

cosmos-sdk/x/auth/keeper/grpc_query.go

Line 37 in 3856e77

address, err := s.k.Accounts.Indexes.Number.MatchExact(ctx, accID)

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Bug Fixes
  • Updated CLI query functionality to allow querying an address by account number using account_id instead of id, improving the accuracy of address retrieval.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request focus on updating the querying mechanism within the CLI module of the application. Specifically, the functionality for querying an address by account number has been modified to use account_id instead of the previous id. This update is reflected in the CHANGELOG.md and involves changes to the AutoCLIOptions method in the x/auth/autocli.go file, ensuring that the command options align with the new parameter naming convention.

Changes

File Path	Change Summary
CHANGELOG.md	Added a bug fix entry for querying an address by account number using account_id instead of id.
x/auth/autocli.go	Updated PositionalArgs in AutoCLIOptions method to change ProtoField from "id" to "account_id".

Possibly related PRs

• chore: add releases to changelog #21831: This PR updates the CHANGELOG.md to include various changes, including bug fixes and new features, which is directly related to the main PR's modification of the changelog for a bug fix in the CLI module.

Suggested labels

C:CLI

Suggested reviewers

• julienrbrt
• testinginprod
• sontrinh16

Warning

Review ran into problems

🔥 Problems

Error running LanguageTool: LanguageTool error: Unknown error

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

CHANGELOG.md (2)

Line range hint 1-3: Unreleased section needs update

The "Unreleased" section is empty. It's a good practice to keep this section updated with ongoing changes that haven't been released yet. Consider adding recent changes or removing this section if there are no unreleased changes to report.

---

Line range hint 3129-3133: Consider updating older changelog entries

The changelog includes entries for very old versions (e.g., v0.40.0). Consider moving these older entries to a separate historical changelog file to keep the main CHANGELOG.md more focused on recent and relevant changes.

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 3856e77 and 47893cd.

📒 Files selected for processing (2)

• CHANGELOG.md (1 hunks)
• x/auth/autocli.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

x/auth/autocli.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

🔇 Additional comments not posted (8)

x/auth/autocli.go (1)

41-41: Approve change and suggest verification

The update from "id" to "account_id" aligns with the PR objective of avoiding the "id isn't supported" error. This change improves the clarity and specificity of the field name, which should resolve the issue.

To ensure consistency across the codebase:

1. Verify that the AccountAddressByID RPC method in the corresponding protobuf definition uses account_id as the field name.
2. Check if any client code or documentation referencing this CLI command needs to be updated.

Run the following script to assist in this verification:

✅ Verification successful

Further Verification Needed: Unable to Locate Protobuf Definitions

The search for rpc AccountAddressByID in protobuf definitions did not yield results due to unrecognized file type. Please run the following script to search without specifying the file type:

---

Change Verified: 'id' successfully replaced with 'account_id'

The update from "id" to "account_id" has been verified across protobuf definitions, codebase, and documentation. This ensures consistency and alignment with the PR objectives, effectively resolving the "id isn't supported" error.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify consistency of AccountAddressByID usage and potential impacts

# Test 1: Check protobuf definition
echo "Checking protobuf definition for AccountAddressByID:"
rg --type proto "rpc AccountAddressByID"

# Test 2: Look for potential client code using this RPC method
echo "Checking for client code using AccountAddressByID:"
rg "AccountAddressByID"

# Test 3: Search for documentation mentioning the CLI command
echo "Checking for documentation mentioning address-by-acc-num:"
rg "address-by-acc-num"

Length of output: 38163

---

Script:

#!/bin/bash
# Description: Verify protobuf definitions of AccountAddressByID without specifying file type

echo "Searching for 'rpc AccountAddressByID' in all proto files:"
rg "rpc AccountAddressByID" --glob "*.proto"

Length of output: 318

CHANGELOG.md (7)

Line range hint 5-8: Important security update in v0.47.16

This release contains a critical security fix for the x/feegrant module. Users should upgrade immediately to address the infinite feegrant allowance bug.

---

Line range hint 12-15: Significant changes in v0.47.0

The v0.47.0 release includes major changes such as the migration to CometBFT and numerous API breaking changes. Users should carefully review the upgrade guide and test their applications thoroughly before upgrading.

---

Line range hint 17-21: New features in v0.47.0

Several new features have been added, including support for SIGN_MODE_TEXTUAL, improvements to x/gov module, and new CLI commands. These additions enhance the functionality and usability of the SDK.

---

Line range hint 23-28: API Breaking Changes in v0.47.0

Numerous API breaking changes are listed, including changes to module interfaces, removal of deprecated functions, and updates to various types. Developers should carefully review these changes and update their code accordingly.

---

Line range hint 30-34: State Machine Breaking Changes in v0.47.0

Several state machine breaking changes are listed, including updates to x/gov, x/group, and x/staking modules. Chain operators should pay close attention to these changes when planning upgrades.

---

Line range hint 36-40: Bug Fixes in v0.47.0

Multiple bug fixes are listed, addressing issues in various modules and components. These fixes improve the stability and reliability of the SDK.

---

Line range hint 42-46: Deprecated Features in v0.47.0

Several features and functions have been deprecated. Developers should take note of these and plan to update their code to use the recommended alternatives.