fix(x/consensus)!: update cons params parsing checks

[MSalopek]

Description

Closes: #21483

Extend consensus params MsgUpdateParams validation.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Bug Fixes
  • Resolved a nil pointer dereference issue in the consensus module, enhancing stability and reliability.
  • Improved parameter handling by ensuring the Version field is always initialized, preventing potential runtime errors.

[coderabbitai]

Walkthrough

Walkthrough

The changes made to the x/consensus module address a bug related to the MsgUpdateParams functionality, specifically resolving a nil pointer dereference issue. The modifications ensure that the Version field of the paramsProto object is properly initialized, enhancing the stability of the consensus parameters during governance proposals.

Changes

Files	Change Summary
x/consensus/CHANGELOG.md	Added entry for bug fix related to MsgUpdateParams addressing nil pointer dereference issue.
x/consensus/keeper/keeper.go	Modified paramCheck function to initialize Version field of paramsProto if nil.

Assessment against linked issues

Objective	Addressed	Explanation
Fix nil pointer dereference in MsgUpdateParams (21483)	✅
Ensure Version is initialized to prevent runtime errors (21483)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[julienrbrt]

ACK!

[julienrbrt]

Can you actually delete this? I know it's unusual to not ask for a changelog but now that we have 0.52 in beta it's actually more work to remove when we backport all the way down.l 😅

[MSalopek]

Yes, removing.

EDIT:
removed

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b33ed07 and 2652461.

Files selected for processing (2)

• x/consensus/CHANGELOG.md (1 hunks)
• x/consensus/keeper/keeper.go (1 hunks)

Additional context used

Path-based instructions (2)

x/consensus/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

x/consensus/keeper/keeper.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (2)

x/consensus/CHANGELOG.md (1)

38-38: Changelog Entry Review: Correct and Relevant

The new changelog entry correctly documents the resolution of a nil pointer dereference issue during the MsgUpdateParams operation. It is well-integrated within the existing structure and follows the prescribed format for changelog entries.

x/consensus/keeper/keeper.go (1)

123-126: Code Review: Correct Initialization to Prevent Nil Pointer Dereference

The addition of the nil check and initialization for paramsProto.Version is correctly implemented and crucial for preventing runtime errors. The style and structure conform to the Uber Golang style guide.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b33ed07 and 2652461.

Files selected for processing (2)

• x/consensus/CHANGELOG.md (1 hunks)
• x/consensus/keeper/keeper.go (1 hunks)

Additional context used

Path-based instructions (2)

x/consensus/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

x/consensus/keeper/keeper.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (2)

x/consensus/CHANGELOG.md (1)

38-38: Changelog Update Approved

The addition to the changelog correctly documents the critical fix made to avoid nil pointer dereference during the MsgUpdateParams operation. Although there was a suggestion to avoid changelog entries for version 0.52, this entry is crucial for understanding the changes made and their impact on the system.

x/consensus/keeper/keeper.go (1)

123-126: Critical Fix Approved

The addition of a conditional check to initialize the Version parameter if it is nil is a crucial improvement. This change ensures that the Version parameter is always initialized, preventing potential nil pointer dereferences and enhancing the robustness of the consensus module.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

x/consensus/keeper/keeper.go (1)

123-126: Proper initialization of Version field to prevent nil pointer dereferences.

The added conditional check in the paramCheck function correctly initializes the Version field if it is nil, aligning with the PR objectives to enhance stability and prevent runtime errors. The implementation is clear and follows good Golang practices.

Consider adding a comment above the conditional check to explain why the initialization is necessary, enhancing code readability and maintainability.

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b33ed07 and 2652461.

Files selected for processing (2)

• x/consensus/CHANGELOG.md (1 hunks)
• x/consensus/keeper/keeper.go (1 hunks)

Additional context used

Path-based instructions (2)

x/consensus/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

x/consensus/keeper/keeper.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (1)

x/consensus/CHANGELOG.md (1)

38-38: Changelog entry is accurate and well-formatted.

The new entry in the changelog correctly describes the resolution of a critical bug, aligns with the PR objectives, and follows the established changelog guidelines.