18 Sep 19:29

github-actions

0083a13

1.43.0 Latest

Latest

Merged PRs

dolt

8367: mark unscoped commit index as not unique
The index defined over the commit_hash column was marked as unique, when it definitely is not.
Along with fix from dolthub/go-mysql-server#2665
fixes #8365
8363: \edit support in dolt sql shell
Enable users to edit multiline queries in their EDITOR of choice. This is awkward to test, so punting on that for the time being.
8359: More flexible diff printing when schema changes type of column
This partially addresses an old bug described in the fixed issue. There are certainly more complete solutions, but this seems like the right amount of effort for something pretty edge casey.
Fixes: #8133

8356: Compare strings with strings.EqualFold

This PR fixes a Staticcheck warning (https://staticcheck.dev/docs/checks/#SA6005). Comparing two strings to the same case with strings.ToLower and strings.ToUpper is more computational expensive than strings.EqualFold.
Sample benchmark:

func BenchmarkToUpperSingle(b *testing.B) {
  for i := 0; i < b.N; i++ {
    if strings.ToUpper("foobar") != "FOOBAR" {
      b.Fail()
    }
  }
}
func BenchmarkToUpperDouble(b *testing.B) {
  for i := 0; i < b.N; i++ {
    if strings.ToUpper("foobar") != strings.ToUpper("FOOBAR") {
      b.Fail()
    }
  }
}
func BenchmarkToLowerSingle(b *testing.B) {
  for i := 0; i < b.N; i++ {
    if strings.ToLower("FOOBAR") != "foobar" {
      b.Fail()
    }
  }
}
func BenchmarkToLowerDouble(b *testing.B) {
  for i := 0; i < b.N; i++ {
    if strings.ToLower("FOOBAR") != strings.ToLower("foobar") {
      b.Fail()
    }
  }
}
func BenchmarkEqualFold(b *testing.B) {
  for i := 0; i < b.N; i++ {
    if !strings.EqualFold("FOOBAR", "foobar") {
      b.Fail()
    }
  }
}

Result:

goos: linux
goarch: amd64
pkg: github.com/dolthub/dolt/go
cpu: AMD Ryzen 7 PRO 4750U with Radeon Graphics
BenchmarkToUpperSingle-16    	 9589896	       113.8 ns/op	       8 B/op	       1 allocs/op
BenchmarkToUpperDouble-16    	 7097330	       155.9 ns/op	       8 B/op	       1 allocs/op
BenchmarkToLowerSingle-16    	12346219	       106.5 ns/op	       8 B/op	       1 allocs/op
BenchmarkToLowerDouble-16    	 8084006	       143.6 ns/op	       8 B/op	       1 allocs/op
BenchmarkEqualFold-16        	63650023	        18.76 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/dolthub/dolt/go	6.456s

8347: Bug fixes for schema names in reset operation
Also factored some methods into the procedure to make it readable
8305: Support for signed commits.

go-mysql-server

2665: Fix FunctionalDependencies for NonUnique, NonNull indexes on Server
When using the server engine, we return an error for indexes defined over non-unique not null columns.
This meant that filters over these columns would incorrectly return error when there were duplicate entries.
Oddly, this only happens on server engine and not using dolt sql-shell directly.
The bug stems from a missing check when gathering functional dependencies for equalities.
Related: #8365
2664: Updated go-icu-regex
2663: [stats] convert binary to string for stats bound rows
tests on Dolt side for round-trip serialization: #8361
2662: implement charset() function
MySQL Docs: https://dev.mysql.com/doc/refman/8.4/en/information-functions.html#function_charset

vitess

365: parse vector index syntax
Supports the following syntax:
- create table t (v blob, vector index(v))
- create vector index vec on t(v)
- alter table t add vector index vec on t(v)
363: support syntax for get_format
MySQL Docs: https://dev.mysql.com/doc/refman/8.4/en/date-and-time-functions.html#function_get-format

Closed Issues

8365: dolt_diff with commit_hash filter errors with result max1Row iterator returned more than one row
8133: \diff doesn't handle decimal diffs. It just prints integers.

Assets 10

13 Sep 22:54

github-actions

v1.42.20

d36ad30

1.42.20

Merged PRs

dolt

8353: Support dolt diff --staged
The common way to look at the staged diff in git is the --staged flag. --cached is still supported, but not recommended (and confusing). This change makes dolt more like git.
8352: Fix dolt_merge_base string validation for doltgres
dolt_merge_base was failing in doltgres with a invalid type: unknown error
8350: [statspro] Restart drop db
Quick fix for at least one of the problems in #8345.
The specific example fails because the restart function refreshes the stats database instance, but does not reload the stats contained within. So the contents in memory did not track the contents on disk. This was only noticeable when restart and read were called within the same shell context.
8348: Testing for dolt add --patch
8343: support for schemas in various version control operations
This change adds support for schemas in dolt_add, dolt_merge, and dolt_status. Many places that had a string for a table name now have a doltdb.TableName.
Also fixes a newly discovered bug with creating a database:
1. creating a DB with a collation left the working set dirty
2. DBs created in a transaction couldn't be queried until starting a new tx
8341: Fix more stats collection races
fixes: #8339
The concurrency tests stopped working at some point when we were rearranging the default stats behavior. I caught a couple other issues after I got those tests running again.
8320: Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows
Bumps actions/download-artifact from 3 to 4.1.7.
Release notes

Sourced from actions/download-artifact's releases.
v4.1.7

What's Changed
- Update @actions/artifact dependency by @bethanyj28 in actions/download-artifact#325
Full Changelog: actions/download-artifact@v4.1.6...v4.1.7

v4.1.6

What's Changed
- updating @actions/artifact dependency to v2.1.6 by @eggyhead in actions/download-artifact#324
Full Changelog: actions/download-artifact@v4.1.5...v4.1.6

v4.1.5

What's Changed
- Update readme with v3/v2/v1 deprecation notice by @robherley in actions/download-artifact#322
- Update dependencies @actions/core to v1.10.1 and @actions/artifact to v2.1.5
Full Changelog: actions/download-artifact@v4.1.4...v4.1.5

v4.1.4

What's Changed
- Update @actions/artifact by @bethanyj28 in actions/download-artifact#307
Full Changelog: actions/download-artifact@v4...v4.1.4

v4.1.3

What's Changed
- Update release-new-action-version.yml by @konradpabjan in actions/download-artifact#292
- Update toolkit dependency with updated unzip logic by @bethanyj28 in actions/download-artifact#299
- Update @actions/artifact by @bethanyj28 in actions/download-artifact#303
New Contributors
- @bethanyj28 made their first contribution in actions/download-artifact#299
Full Changelog: actions/download-artifact@v4...v4.1.3

v4.1.2
- Bump @actions/artifacts to latest version to include updated GHES host check
v4.1.1
- Fix transient request timeouts actions/download-artifact#249
- Bump @actions/artifacts to latest version
v4.1.0

What's Changed
- Some cleanup by @robherley in actions/download-artifact#247
- Fix default for run-id by @stchr in actions/download-artifact#252
... (truncated)
Commits
- 65a9edc Merge pull request #325 from bethanyj28/main
- fdd1595 licensed
- c13dba1 update @actions/artifact dependency
- 0daa75e Merge pull request #324 from actions/eggyhead/use-artifact-v2.1.6
- 9c19ed7 Merge branch 'main' into eggyhead/use-artifact-v2.1.6
- 3d3ea87 updating license
- 89af5db updating artifact package v2.1.6
- b4aefff Merge pull request #323 from actions/eggyhead/update-artifact-v215
- 8caf195 package lock update
- d7a2ec4 updating package version
- Additional commits viewable in compare view
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/download-artifact&package-manager=github_actions&previous-version=3&new-version=4.1.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close thi...

Assets 10

09 Sep 23:37

github-actions

v1.42.19

9eb1a3d

1.42.19

Merged PRs

dolt

8336: dolt add --patch
CLI update to enable the "--patch" option for dolt add.
This option is only supported in a CLI context (sql shell included) because the dolt_add stored procedure doesn't allow for a user interactive workflow.
Currently this change lacks tests. I'll work on that after I ship the blog post.
Fixes: #2465
8335: [statspro] Avoid stopping the world during stats updates
The stats provider holds a lock that was required to (1) update stats, and (2) access statistics.
The new behavior
- Reject duplicate update requests on the same database/branch/table. So an analyze table <t> will error if a conflicting job is active.
- Only lock the provider in critical sections. Update threads only grab the lock to read current statistics or write updates. So regular reads/writes will not hang waiting for the stats provider mutex longer than it takes to finish a critical section.
8334: Fix issue where stats db created in wrong location
fixes: #8324

Closed Issues

2465: Support dolt add -p
8324: call dolt_stats_restart() executed using dolt sql -q in the root of the database puts stats in the wrong place
8317: SELECT WHERE (id = x AND id = y) returns row matching y instead of no results
8316: Sqlalchemy can't reflect schema with foreign key

Assets 10

05 Sep 05:59

github-actions

v1.42.18

74cb601

1.42.18

Merged PRs

dolt

8321: Optional String Argument
support optional string arguments in the middle of command line args.
8319: reset auto increment counter on dolt_reset('--hard')
When calling dolt_reset(--hard), we don't properly reload the auto increment value from the global tracker.
The bug is a side effect from maintaining auto increment value between branches. We track the last greatest auto increment value across all branches in the session, and dropping a table sets the previous auto_increment value to 0.
The fix is to get the tracker to reload values when resetting.
Some notable behavior here is that a dolt_reset over insert will not reset the auto_increment tracker.
fixes: #8272
8314: Fix Integration Workflow
This is Dolt's counterpart to the following PR:
- dolthub/go-mysql-server#2644
8313: Fixed table resolution for reset
8309: Minor doc updates
8306: Export DoltSystemVariables var so that it can be used by doltgres

go-mysql-server

2651: fix collations with recursive hash for HashInTuple expressions
When hashing tuples, we don't take into account the collation of the individual elements, which results in incorrect comparisons for case insensitive collations.
The fix here was to recursively hash each individual element in a tuple, and hash the slice of hashes.
fixes #8316
2650: conflict in EqualityRangeBuilder
Fix bug in equality range builder where duplicate equality filters to one value would stomp each other.
fixes: #8317
dolt-side: #8322
2645: Fix revision databases not showing up for schema databases

Closed Issues

8317: SELECT WHERE (id = x AND id = y) returns row matching y instead of no results
8330: Unique index not used when there is an IN expression in conditional
8333: Class of Query intermittently slow on Wikipedia Import to Media Wiki
8332: Slow query on where clause in composite primary key
8316: Sqlalchemy can't reflect schema with foreign key
8331: Slow query on wikipedia import to Media Wiki
8272: dolt_reset(--hard) after a drop table reserts the auto_increment counter to 1
8308: Empty result set from query with INNER JOIN + WHERE

Performance

Read Tests	MySQL	Dolt	Multiple
covering_index_scan	2.07	0.67	0.3
groupby_scan	13.22	16.41	1.2
index_join	1.37	2.66	1.9
index_join_scan	1.3	2.11	1.6
index_scan	34.33	54.83	1.6
oltp_point_select	0.18	0.3	1.7
oltp_read_only	3.49	5.88	1.7
select_random_points	0.34	0.67	2.0
select_random_ranges	0.39	0.7	1.8
table_scan	34.95	54.83	1.6
types_table_scan	75.82	144.97	1.9
reads_mean_multiplier			1.6

Write Tests	MySQL	Dolt	Multiple
oltp_delete_insert	8.13	5.99	0.7
oltp_insert	3.82	2.97	0.8
oltp_read_write	8.58	11.87	1.4
oltp_update_index	3.89	3.02	0.8
oltp_update_non_index	3.89	2.97	0.8
oltp_write_only	5.37	6.09	1.1
types_delete_insert	7.7	6.43	0.8
writes_mean_multiplier			0.9

TPC-C TPS Tests	MySQL	Dolt	Multiple
tpcc-scale-factor-1	98.44	39.11	2.5
tpcc_tps_multiplier			2.5

Overall Mean Multiple	1.67

Assets 10

30 Aug 01:02

github-actions

v1.42.17

6a3ca26

1.42.17

Merged PRs

dolt

8311: [kvexec] fix more lookup bugs related to schema/projection inconsistencies
We were using the full table schema to index a covering index KV pair. The fix has to be sensitive to covering, non-covering, and keyless tables, which required extra tests on the GMS side to check all cases.
fixes: #8308
re: dolthub/go-mysql-server#2646
8303: Perf: Optimize SQL transaction commits in binlog replication applier
The binlog replication applier process is responsible for applying the replicated updates from a MySQL source to the Dolt replica. Previously, when committing SQL transactions after applying a change, the applier would attempt to commit on all known databases. This worked when the number of databases was small, but when the server is handling hundreds of databases, it adds noticeable and unnecessary delay. This change switches to use the dirty tracking data of the session to more efficiently commit to only the databases that have had changes applied.
Performance Comparison
The old SQL transaction commit logic scaled exponentially, while the new logic scales linearly.

Num Databases Code Path Replication Time (s)

100 Old 11.02

300 Old 144.34

500 Old 633.44

100 New 6.79

300 New 20.51

500 New 36.04

Num Databases	Code Path	Replication Time (s)
100	Old	11.02
300	Old	144.34
500	Old	633.44
100	New	6.79
300	New	20.51
500	New	36.04

8294: Feature: Data conflict resolution during interactive rebase
When data conflicts occur during an interactive rebase, customers can now use Dolt's conflict resolution tools to resolve the conflicts and continue the rebase operation. Note that schema conflicts are not supported yet.
Example:

> select * from dolt_rebase;
+--------------+--------+----------------------------------+----------------------------+
| rebase_order | action | commit_hash                      | commit_message             |
+--------------+--------+----------------------------------+----------------------------+
| 1.00         | drop   | iumpo2t0hd6drcn11jo8osdack1jmafp | inserting row 1 on branch1 |
| 2.00         | pick   | us2uaji20dj77cnf1i2l698itr5392se | updating row 1 on branch1  |
+--------------+--------+----------------------------------+----------------------------+
> call dolt_rebase('--continue');
data conflict detected while rebasing commit us2uaji20dj77cnf1i2l698itr5392se (updating row 1 on branch1).
Resolve the conflicts and remove them from the dolt_conflicts_<table> tables, then continue the rebase by calling dolt_rebase('--continue')
> select * from dolt_conflicts_t;
+----------------------------------+---------+---------+--------+--------+---------------+----------+----------+-----------------+------------------------+
| from_root_ish                    | base_pk | base_c1 | our_pk | our_c1 | our_diff_type | their_pk | their_c1 | their_diff_type | dolt_conflict_id       |
+----------------------------------+---------+---------+--------+--------+---------------+----------+----------+-----------------+------------------------+
| us2uaji20dj77cnf1i2l698itr5392se | 1       | one     | NULL   | NULL   | removed       | 1        | uno      | modified        | B1dLxGtGIlHRKJo88tigpw |
+----------------------------------+---------+---------+--------+--------+---------------+----------+----------+-----------------+------------------------+
> call dolt_conflicts_resolve('--theirs', 't');
+--------+
| status |
+--------+
| 0      |
+--------+
> call dolt_add('t');
> call dolt_rebase('--continue');
+--------+-----------------------------------------------------+
| status | message                                             |
+--------+-----------------------------------------------------+
| 0      | Successfully rebased and updated refs/heads/branch1 |
+--------+-----------------------------------------------------+

Customer issue: #7820

go-mysql-server

2644: Fix Integration Workflow
This makes a few changes to how the integration workflow is handled:
- main is now merged into this PR before testing. Previously, we would just use the PR as-is, which created a situation where the main branch included changes that the PR had not yet merged in. This created an issue as Dolt and DoltgreSQL would expect some changes to be present that were not yet merged into the PR, causing compilation errors. By merging main, we bypass this. In addition, the workflow will automatically pass if a merge conflict is detected. I think this is fine, since conflicts must be resolved before the PR can be merged anyway. This does mean that some errors may not be caught for as long as merge conflicts against main exist.
- We only pulled comments, and the PR description does not count as a comment. This made it seem a bit inconsistent with how PR detection was handled. This has now been added, and we're now doing a basic string search instead of using a JSON parser, as concatenating the comments and description does not result in a valid JSON object.
- Workflow should automatically run when a comment is added, modified, or deleted. This was already supposed to happen, but the event structure differed between a comment and push in a subtle way, causing the workflow to immediately error and for the UI to continue displaying the previous run. This made it seem as though the workflow did not respond to comment updates.
- Additional logging messages have been added, so it's easier to debug if something goes wrong in the future.
2641: Correctly handle indexes on virtual columns
Fixes #8276
Lots of small behaviors around virtual columns were not working correctly:
- Adding an index on a virtual column triggered a table rebuild even when this wasn't necessary
- Rebuilding a table that contained virtual columns could lead to incorrect results
- Inserting into a table with a virtual column could update indexes incorrectly
- Adding a generated column to the start of a table could lead to incorrect results
  This PR adds tests for these cases and fixes them by tweaking the logic for projections on tables with generated columns.

Closed Issues

8308: Empty result set from query with INNER JOIN + WHERE

Performance

Read Tests	MySQL	Dolt	Multiple
covering_index_scan	2.07	0.65	0.3
groupby_scan	13.7	16.71	1.2
index_join	1.37	2.66	1.9
index_join_scan	1.3	2.11	1.6
index_scan	34.95	54.83	1.6
oltp_point_select	0.18	0.3	1.7
oltp_read_only	3.49	5.77	1.7
select_random_points	0.34	0.67	2.0
select_random_ranges	0.39	0.69	1.8
table_scan	34.95	54.83	1.6
types_table_scan	75.82	144.97	1.9
reads_mean_multiplier			1.6

Write Tests	MySQL	Dolt	Multiple
oltp_delete_insert	8.13	5.99	0.7
oltp_insert	3.82	2.97	0.8
oltp_read_write	8.58	11.87	1.4
oltp_update_index	3.89	3.02	0.8
oltp_update_non_index	3.89	2.97	0.8
oltp_write_only	5.37	6.09	1.1
types_delete_insert	7.7	6.43	0.8
writes_mean_multiplier			0.9

TPC-C TPS Tests	MySQL	Dolt	Multiple
tpcc-scale-factor-1	98.27	39.08	2.5
tpcc_tps_multiplier			2.5

Overall Mean Multiple	1.67

Assets 10

28 Aug 22:06

github-actions

v1.42.16

9d85831

1.42.16

Merged PRs

dolt

8300: Fix nil panic in using dolt show to inspect secondary indexes.
8299: More consistent return types for dolt procedures
Most procedures that return integers return int64, but there are a few exceptions. The procedures that return int break in doltgres here
8297: dolt_workspace_* update and delete support
This change adds the ability to update dolt_workspace_ tables. Updates can take two forms:
1. The "staging" column of the table. may be toggled from it's current state. If setting from false to true, the working value will be written into the staged table. Setting from true to false will remove the row from staging, and leave the value in working as is.
2. You can delete any row which has a "staged" column of false. This will revert the workspace changes and return them to the original value.
8186: Add support for Doltgres indexes
- dolthub/doltgresql#561

go-mysql-server

2641: Correctly handle indexes on virtual columns
Fixes #8276
Lots of small behaviors around virtual columns were not working correctly:
- Adding an index on a virtual column triggered a table rebuild even when this wasn't necessary
- Rebuilding a table that contained virtual columns could lead to incorrect results
- Inserting into a table with a virtual column could update indexes incorrectly
- Adding a generated column to the start of a table could lead to incorrect results
  This PR adds tests for these cases and fixes them by tweaking the logic for projections on tables with generated columns.
2638: Change ranges to an interface
- #8186

Closed Issues

8276: Indexes on virtual generated columns generate incorrect results.

Performance

Read Tests	MySQL	Dolt	Multiple
covering_index_scan	2.07	0.65	0.3
groupby_scan	13.22	16.41	1.2
index_join	1.37	2.66	1.9
index_join_scan	1.27	2.11	1.7
index_scan	34.33	54.83	1.6
oltp_point_select	0.18	0.3	1.7
oltp_read_only	3.49	5.77	1.7
select_random_points	0.34	0.65	1.9
select_random_ranges	0.39	0.69	1.8
table_scan	34.33	54.83	1.6
types_table_scan	75.82	142.39	1.9
reads_mean_multiplier			1.6

Write Tests	MySQL	Dolt	Multiple
oltp_delete_insert	8.13	5.99	0.7
oltp_insert	3.82	3.02	0.8
oltp_read_write	8.58	11.87	1.4
oltp_update_index	3.89	3.02	0.8
oltp_update_non_index	3.89	2.97	0.8
oltp_write_only	5.37	6.21	1.2
types_delete_insert	7.7	6.43	0.8
writes_mean_multiplier			0.9

TPC-C TPS Tests	MySQL	Dolt	Multiple
tpcc-scale-factor-1	99.27	39.96	2.5
tpcc_tps_multiplier			2.5

Overall Mean Multiple	1.67

Assets 10

26 Aug 23:14

github-actions

v1.42.15

1e96895

1.42.15

Merged PRs

dolt

8296: fix case insensitive column match in kv iter
When building the keyLookupMapper for the special prolly tree kvIter, we match column names by exact casing. This leads to incorrect lookup indexes.
The fix was to use lowercase when matching.
companion pr: dolthub/go-mysql-server#2640
8295: Update README.md
8292: working?
8291: [commands] faster sqldump query scanner
The default sqldump scanner works as follows:
- (1) read +4k lines into buffer
- (2) scan entire buffer for delimiter (starting from index 0)
- (3) failing to find delimiter, go to step 1
  So if the delimiter is at character 16k, we will execute the loop 4 times. I noticed some maybe weird things about the default buffered reader from a cursory glance that I might be misunderstanding: (i) it copies bytes between at least 3 buffers (src, dst, target), (ii) do double IO for reads (the bufio docs say this, I didn't completely follow where it happens), and (iii) when doubling the buffer capacity reread the initial contents again (tracking the size of the buffer, it seems to increase and then decrease slightly at doubling implements. There might be something else going on here).
  Anyway, this prototype just doesn't do any of that. Just stream the bytes seeking a delimiter.
  Prototype goes from ~10seconds to import 10k lines -> 1 second on the motivating test dataset.
Update with tests passing:
```
before
maxhoffman@Maxs-MacBook-Pro ~/D/d/indexer> time dolt sql < doltdump.sql &> log
________________________________________________________
Executed in  276.23 secs    fish           external
usr time  276.57 secs    0.19 millis  276.57 secs
sys time    2.70 secs    1.72 millis    2.70 secs
after:
maxhoffman@Maxs-MacBook-Pro ~/D/d/indexer> time dolt sql < doltdump.sql &> log
________________________________________________________
Executed in   33.79 secs    fish           external
usr time   38.18 secs    0.21 millis   38.18 secs
sys time    0.64 secs    1.78 millis    0.64 secs
```
Update after not double-parsing every query:
```
maxhoffman@Maxs-MacBook-Pro ~/D/d/indexer> time dolt sql < doltdump.sql &> log
________________________________________________________
Executed in   25.60 secs    fish           external
usr time   30.31 secs    0.28 millis   30.31 secs
sys time    0.56 secs    1.21 millis    0.56 secs
```

go-mysql-server

Closed Issues

Assets 10

22 Aug 02:54

github-actions

v1.42.14

9452871

1.42.14

Merged PRs

dolt

8289: User Contribution Fixup
Revised: #8246
Fixes: #8221
8288: Skip filter iter, with more test fixes
This is the same as #8242 with one change and new test in GMS dolthub/go-mysql-server#2639. The change prevents string comparisons from skipping range.Matches, because the index range iterators can return false positives/prefix matches.
8281: Db/dolt ci events init
8246: Fixed grammar typos re issue #8221
Solved ./go typos as requested in #8221. This was my first-ever big project contribution, even if it's simple, so hope I followed procedure appropriately :)

go-mysql-server

2637: Adding a test combining duplicate indexes through create table and alter table
Additional test case for dolthub/go-mysql-server#2634
2635: Fix multi-statements in nested triggers
changes:
- have different savepoint names
- this fixes nested triggers overwriting save points and clearing the same savepoint
- handle aliases independently for each statement in trigger blocks
- sync up prepend and scope nesting for triggers
- wrap applyTrigger rule wraps triggerExecutors over individual statements in BeginEndBlocks
- this prevents wrapping triggerExecutors over the wrong statements (not matching event or table)
  related: #8213
2634: Adding tests for supporting duplicate secondary indexes
New tests asserting that multiple indexes over the same set of columns can be created on tables.
#8274 fixes Dolt for these tests to pass.

Closed Issues

8221: Fix Grammar Typos in Go Comments
8213: nested (delete) triggers have the wrong context in the nested call
8250: Permission for the home directory: panic: runtime error: invalid memory address or nil pointer dereference

Performance

Read Tests	MySQL	Dolt	Multiple
covering_index_scan	2.18	0.68	0.3
groupby_scan	12.98	16.41	1.3
index_join	1.39	2.66	1.9
index_join_scan	1.3	2.14	1.6
index_scan	34.95	54.83	1.6
oltp_point_select	0.18	0.3	1.7
oltp_read_only	3.49	5.77	1.7
select_random_points	0.34	0.65	1.9
select_random_ranges	0.39	0.69	1.8
table_scan	34.95	54.83	1.6
types_table_scan	75.82	144.97	1.9
reads_mean_multiplier			1.6

Write Tests	MySQL	Dolt	Multiple
oltp_delete_insert	7.98	5.99	0.8
oltp_insert	3.75	2.97	0.8
oltp_read_write	8.58	11.87	1.4
oltp_update_index	3.89	3.02	0.8
oltp_update_non_index	3.89	2.97	0.8
oltp_write_only	5.37	6.09	1.1
types_delete_insert	7.7	6.43	0.8
writes_mean_multiplier			0.9

TPC-C TPS Tests	MySQL	Dolt	Multiple
tpcc-scale-factor-1	100.08	39.36	2.5
tpcc_tps_multiplier			2.5

Overall Mean Multiple	1.67

Assets 10

16 Aug 18:24

github-actions

v1.42.13

9e7fa22

1.42.13

Merged PRs

dolt

8274: Allow duplicate indexes, to match MySQL behavior
This change allows Dolt to create multiple indexes on a table to cover the same set of columns, to match MySQL's behavior. While duplicate indexes are not generally useful, some MySQL tooling (e.g. Django) can create duplicate indexes as part of generated schema migration code.
Test for creating duplicate indexes were added to GMS, in the PR below. I also tested merge behavior with duplicate indexes and confirmed that we already have a guardrail in place to prevent merging multiple indexes that cover the same set of columns, and a test for that guardrail.
GMS PR: dolthub/go-mysql-server#2634
Customer issue: #8254
8273: ResolveDefaultExpression should return a ColumnDefaultValue instance, because it has information about the type of the column and performs conversions.
Fixes #8269
We were removing the ColumnDefaultValue expression node when building secondary indexes, which was a problem when the type of the default value needed to be converted to the column type: it's the ColumnDefaultValue expression that does that conversion.
8268: Db/dolt ci events
8260: Fixes for dolt installer bash-script
1. Fixed error message mistakenly implying that dolt can be installed on 32-bit systems
2. Fixed color printing on bash (and zsh running in bash compatibility mode) installed on an OS with non-GNU coreutils (Alpine Linux, macOS)
3. Linted install.sh and fixed all the errors and warning that had obvious fixes. The only one left is local error_code="$1" in fail function that should be removed but may be reused for debugging purposes by manually editing the script
8253: Add dolt_workspace_* system tables
This is the read only addition of the dolt_workspace_{table} s. These dynamically generated tables are always relative to HEAD for the given session of the caller. There are no commits as a result, and the schema of the output looks like:
| ID (int) | STAGED (bool) | DIFF_TYPE (string) | to_A | to_B | ... | from_A | from_B | ... |
Currently there is no mechanism to update this table directly, but in the future that will make it possible to have fine grain modification of your workspace, similar to git add --patch
8242: Skip filterIter match check when a key range is contiguous

go-mysql-server

2636: Add additional engine tests for indexes on generated columns.
These tests verify the correctness of #8273.
Some of the checks in these tests are skipped because they run afoul of #8275 and #8276
2634: Adding tests for supporting duplicate secondary indexes
New tests asserting that multiple indexes over the same set of columns can be created on tables.
#8274 fixes Dolt for these tests to pass.
2633: handle view resolution when the schema is not defined in SELECT stmt
2631: include parent scopes in update and delete triggers
partially fixes #8213
2628: Aggregation/range scan perf edits
- Resolving aggregation functions checks the integrator function provider first. The interface required us to create an expensive error object to resolve any standard functions. Now we only create the error object if a function name is not found in integrator and standard list.
- Skip duplicate unused functional dependency tracking in coster.
- Aggregations with no group by and single scopes can only return one row, so use the sql.QFlagMax1Row shortcut.
  benchmarks here: #8241

Closed Issues

8254: Adding a duplicate constraint with a new name overwrites the existing constraint rather than coexisting
8269: Panic when creating index on generated column
7830: Support --empty flag for handling empty commits during rebase
8250: Permission for the home directory: panic: runtime error: invalid memory address or nil pointer dereference

Performance

Read Tests	MySQL	Dolt	Multiple
covering_index_scan	2.07	1.06	0.5
groupby_scan	13.22	17.01	1.3
index_join	1.32	2.66	2.0
index_join_scan	1.25	2.14	1.7
index_scan	34.33	54.83	1.6
oltp_point_select	0.18	0.3	1.7
oltp_read_only	3.49	5.77	1.7
select_random_points	0.34	0.65	1.9
select_random_ranges	0.39	0.7	1.8
table_scan	34.33	54.83	1.6
types_table_scan	74.46	147.61	2.0
reads_mean_multiplier			1.6

Write Tests	MySQL	Dolt	Multiple
oltp_delete_insert	8.13	5.99	0.7
oltp_insert	3.82	3.02	0.8
oltp_read_write	8.58	11.87	1.4
oltp_update_index	3.89	3.02	0.8
oltp_update_non_index	3.89	2.97	0.8
oltp_write_only	5.37	6.09	1.1
types_delete_insert	7.7	6.43	0.8
writes_mean_multiplier			0.9

TPC-C TPS Tests	MySQL	Dolt	Multiple
tpcc-scale-factor-1	96.5	38.71	2.5
tpcc_tps_multiplier			2.5

Overall Mean Multiple	1.67

Assets 10

13 Aug 21:24

github-actions

v1.42.11

c540b7f

1.42.11

Merged PRs

dolt

8261: liuliu/graph-spaces-fix
8259: liuliu/graph-remove-extra-s
8258: Bug fix: Testing for invalid global configuration dir permissions earlier, to prevent a panic
Customer issue: #8250
8252: go/store/nbs: Fix table_index for table files with so many chunks that certain index slice operations overflow a uint32.
8251: liuliu/color-string-fix
8248: support \checkout, \merge, \show
Until now there was an awkward behavior in dolt sql shell where the \checkout and \merge commands didn't really play nice when they could have. Specifically, if you used dolt sql and it was connected to a remote host, then running \checkout would give you an error telling you to stop the server. That is no longer the case. \checkout and \merge will work well in the dolt sql shell when connected to a remote host now.
Also added the \show command
And made the expect tests more correct and expanded.
8247: Fix displaying AddressMap non-leaf nodes in noms show
This fixes an index out of bounds panic when trying to display AddressMap non-leaf nodes in noms show.
I didn't add a regression test, because it turns out that all noms show tests only work against the old deprecated format, so adding more tests to the test suite wouldn't actually do anything. It's also mostly unused: we basically only use it as part splunk.pl to visualize chunks for debugging.
Instead of fixing the test suite, it would be a better use of my time to fully deprecate noms show and switch splunk.pl to use dolt show instead. Especially now that #8143 added support for visualizing prolly tree chunks in dolt show, bringing it to feature parity with noms show.

8245: Feature: support for --empty=[drop|keep] in dolt_rebase()
Adds support for the --empty option to dolt_rebase(). This option controls how commits that become empty are handled. For example, if a branch is rebased and all the changes in one commit on that branch have already been applied to the upstream branch, then when that commit is reapplied, it will end up being empty. The two initially supported values are drop and keep. (Git also supports a stop value, which lets the user manually intervene.)
Also adds support for the --allow-empty flag for dolt_cherry_pick(). This flag controls whether Dolt will cherry-pick empty commits (i.e. commits that start off as empty, not commits that become empty after they are applied).
These behaviors are slightly confusing for two reasons: 1) Git distinguishes between a commit that starts off empty and a commit that becomes empty while applying its changes, and 2) rebase and cherry-pick have slightly different default values for these two options. The differences are summarized below.

	Commits that start empty	Commits that become empty
`rebase`	default: `keep`, can be overridden with `--no-keep-empty` (`--keep-empty` is also supported)	default: `drop`, can be overridden with `--empty=keep`. For interactive rebases, the default changes to `stop`, which is not supported by Dolt yet.
`cherry-pick`	default: `fail`, can be overridden with `--allow-empty`	default: `stop`, can be overridden with `--empty=keep` or `--empty=drop`. Dolt does not support `stop` yet, so Dolt's default is to fail.
Related issue: #7830

8239: Rewrite the dolt show implementation.
dolt show had an issue where it would not correctly display the SerialMessage for commits if provided with a hash. This came about as part of a refactor to make dolt show not depend on the env.DoltEnv object, when only exists on locally running servers, and not when connected to a remote server. Unfortunately, it looks like that refactor didn't actually remove the dependency either, as DoltEnv was still used in every possible invocation of dolt show
To get it working, I essentially rewrote the implementation of dolt show in such a way that it now actually only uses DoltEnv when it can't get the necessary information from a running server: Basically, if we need to display SerialMessages or resolve branch names, we still rely on a locally running server. This can likely be improved in the future. But calls like dolt show #hash should now work against remote servers.
8226: Liuliu/log one line graph
An example of the graph of us-jails:
8222: [kvexec] customized operator for count aggregation
Operators that count the number of rows in a relation don't have to deserialize those KV's from storage (ex: select count(y) from xy where x > 1). There are some circumstances where we have to check for field nullability, but otherwise we can just count the KV's returned by the source iterator.
8129: Add optimized diffing and three-way merge of indexed JSON Documents.
This PR adds some additional tests, but I plan on adding more tests around large documents before merging. Still, the implementation is ready for review.
This adds a new JSON diffing algorithm designed for IndexedJSONDocument. Because three way merge only operates on values read from a Dolt table, which are always returned as a IndexedJSONDocuemt, this should mean that the original implementation is no longer used.

go-mysql-server

2629: normalize column defaults
This PR adds a new analyzer rule to normalize literal column default values.
This rule ensures that the default value is consistent for the column type (float defaults over int columns are rounded properly).
It does this by evaluating the column default, and placing that into a NewLiteral of the proper type.
Additionally, this ensures that dolt serialization receives consistent values (normalized floats and proper types).
fixes: #8190
2627: Fix error when comparing incompatible types in IndexLookups
When building lookups for IndexedTableAccess, we always convert the key type to the columns type.
This is problematic when the key can't be converted to the column type without error.
The expressions used in Filters properly handle this conversion, so we should default to that.
Example:
```
tmp/main*> create table t (i int primary key);
tmp/main*> select * from t where i = json_array();
error: '[]interface {}' is not a valid value type for 'int'
```
This doesn't errror in MySQL. Also without a primary key or secondary index, the query succeeds in dolt.

2625: Bug fix: the timestamp function should convert to a datetime type
MySQL's timestamp function, despite its name, actually returns a datetime type and not a timestamp type.
MySQL example:

mysql -uroot --protocol TCP -e "select timestamp('1000-01-01 00:00:00');" --column-type-info
Field   1:  `timestamp('1000-01-01 00:00:00')`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       DATETIME
Collation:  binary (63)
Length:     19
Max_length: 19
Decimals:   0
Flags:      BINARY
+----------------------------------+
| timestamp('1000-01-01 00:00:00') |
+----------------------------------+
| 1000-01-01 00:00:00              |
+----------------------------------+

Note: We still need to add support for the second, optional parameter to timestamp().
Customer issue: #8236

Closed Issues

4367: Add support for --graph option in dolt log
8190: Table schema stores unnormalized expression for default values, which leads to unexpected behaviors.
8236: Issue with datetime(6) column using timestamp(6) range

Performance

Read Tests	MySQL	Dolt	Multiple
covering_index_scan	2.07	1.16	0.6
groupby_scan	12.98	16.71	1.3
index_join	1.34	2.66	2.0
index_join_scan	1.27	2.14	1.7
index_scan	34.33	55.82	1.6
oltp_point_select	0.18	0.3	1.7
oltp_read_only	3.43	5.88	1.7
select_random_points	0.33	0.65	2.0
select_random_ranges	0.39	0.81	2.1
table_scan	34.95	55.82	1.6
types_table_scan	75.82	144.97	1.9
reads_mean_multiplier			1.7

Write Tests	MySQL	Dolt	Multiple
oltp_delete_insert	7.98	5.88	0.7
oltp_insert	3.75	2.97	0.8
oltp_read_write	8.43	11.87	1.4
oltp_update_index	3.82	2.9...

Assets 10

Releases: dolthub/dolt

1.43.0

Merged PRs

dolt

go-mysql-server

vitess

Closed Issues

1.42.20

Merged PRs

dolt

v4.1.7

What's Changed

v4.1.6

What's Changed

v4.1.5

What's Changed

v4.1.4

What's Changed

v4.1.3

What's Changed

New Contributors

v4.1.2

v4.1.1

v4.1.0

What's Changed

1.42.19

Merged PRs

dolt

Closed Issues

1.42.18

Merged PRs

dolt

go-mysql-server

Closed Issues

Performance

1.42.17

Merged PRs

dolt

Performance Comparison

go-mysql-server

Closed Issues

Performance

1.42.16

Merged PRs

dolt

go-mysql-server

Closed Issues

Performance

1.42.15

Merged PRs

dolt

go-mysql-server

Closed Issues

1.42.14

Merged PRs

dolt

go-mysql-server

Closed Issues

Performance

1.42.13

Merged PRs

dolt

go-mysql-server

Closed Issues

Performance

1.42.11

Merged PRs

dolt

go-mysql-server

Closed Issues

Performance