Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suggest to use things which weren't found either #39443

Merged
merged 1 commit into from
Feb 5, 2017
Merged

Don't suggest to use things which weren't found either #39443

merged 1 commit into from
Feb 5, 2017

Conversation

phungleson
Copy link
Contributor

@phungleson phungleson commented Feb 1, 2017

Fixes #38054

The best code I can come up with, suggestions are welcome.

Basically, removing . Did you mean to use `DoesntExist1`? in the code below, because it is useless.

error[E0432]: unresolved import `DoesntExist1`
 --> src/lib.rs:1:5
  |
1 | use DoesntExist1;
  |     ^^^^^^^^^^^^ no `DoesntExist1` in the root

error[E0432]: unresolved import `DoesntExist2`
 --> src/lib.rs:2:5
  |
2 | use DoesntExist2;
  |     ^^^^^^^^^^^^ no `DoesntExist2` in the root. Did you mean to use `DoesntExist1`?

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@arielb1
Copy link
Contributor

arielb1 commented Feb 1, 2017

squash & add test?

@nikomatsakis
Copy link
Contributor

Yes, @phungleson, this looks like a good diff, but could you add a regression test? I think you would basically take your example and put it in the ui test suite, so we can check the precise output and make sure we are not giving the suggestion in question. (There are some instructions for the ui test suite in src/test/ui/README.md.)

@nikomatsakis
Copy link
Contributor

Also removing the merge commit would be good =)

@phungleson
Copy link
Contributor Author

@nikomatsakis does it look ok now?

@nikomatsakis
Copy link
Contributor

@bors r+

cc @jseyfried but this seems kind of "obviously not wrong" :)

@bors
Copy link
Contributor

bors commented Feb 2, 2017

📌 Commit 823e185 has been approved by nikomatsakis

@nikomatsakis
Copy link
Contributor

@phungleson looks good! I approved it for merging. The bors bot will take care of it now.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 4, 2017
…, r=nikomatsakis

Don't suggest to use things which weren't found either

Fixes rust-lang#38054

The best code I can come up with, suggestions are welcome.

Basically, removing ```. Did you mean to use `DoesntExist1`?``` in the code below, because it is useless.

```rust
error[E0432]: unresolved import `DoesntExist1`
 --> src/lib.rs:1:5
  |
1 | use DoesntExist1;
  |     ^^^^^^^^^^^^ no `DoesntExist1` in the root

error[E0432]: unresolved import `DoesntExist2`
 --> src/lib.rs:2:5
  |
2 | use DoesntExist2;
  |     ^^^^^^^^^^^^ no `DoesntExist2` in the root. Did you mean to use `DoesntExist1`?
```
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 4, 2017
…, r=nikomatsakis

Don't suggest to use things which weren't found either

Fixes rust-lang#38054

The best code I can come up with, suggestions are welcome.

Basically, removing ```. Did you mean to use `DoesntExist1`?``` in the code below, because it is useless.

```rust
error[E0432]: unresolved import `DoesntExist1`
 --> src/lib.rs:1:5
  |
1 | use DoesntExist1;
  |     ^^^^^^^^^^^^ no `DoesntExist1` in the root

error[E0432]: unresolved import `DoesntExist2`
 --> src/lib.rs:2:5
  |
2 | use DoesntExist2;
  |     ^^^^^^^^^^^^ no `DoesntExist2` in the root. Did you mean to use `DoesntExist1`?
```
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
…, r=nikomatsakis

Don't suggest to use things which weren't found either

Fixes rust-lang#38054

The best code I can come up with, suggestions are welcome.

Basically, removing ```. Did you mean to use `DoesntExist1`?``` in the code below, because it is useless.

```rust
error[E0432]: unresolved import `DoesntExist1`
 --> src/lib.rs:1:5
  |
1 | use DoesntExist1;
  |     ^^^^^^^^^^^^ no `DoesntExist1` in the root

error[E0432]: unresolved import `DoesntExist2`
 --> src/lib.rs:2:5
  |
2 | use DoesntExist2;
  |     ^^^^^^^^^^^^ no `DoesntExist2` in the root. Did you mean to use `DoesntExist1`?
```
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
…, r=nikomatsakis

Don't suggest to use things which weren't found either

Fixes rust-lang#38054

The best code I can come up with, suggestions are welcome.

Basically, removing ```. Did you mean to use `DoesntExist1`?``` in the code below, because it is useless.

```rust
error[E0432]: unresolved import `DoesntExist1`
 --> src/lib.rs:1:5
  |
1 | use DoesntExist1;
  |     ^^^^^^^^^^^^ no `DoesntExist1` in the root

error[E0432]: unresolved import `DoesntExist2`
 --> src/lib.rs:2:5
  |
2 | use DoesntExist2;
  |     ^^^^^^^^^^^^ no `DoesntExist2` in the root. Did you mean to use `DoesntExist1`?
```
bors added a commit that referenced this pull request Feb 5, 2017
@bors bors merged commit 823e185 into rust-lang:master Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't suggest to use things which weren't found either.
5 participants