Fix bootstrap.py issues with new rustbuild build system (fixes #39469) #39471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ Thanks! |
|
📌 Commit 51e5cb5 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 4, 2017
Fix bootstrap.py issues with new rustbuild build system (fixes rust-lang#39469)
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 4, 2017
Fix bootstrap.py issues with new rustbuild build system (fixes rust-lang#39469)
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 5, 2017
Fix bootstrap.py issues with new rustbuild build system (fixes rust-lang#39469)
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 5, 2017
Fix bootstrap.py issues with new rustbuild build system (fixes rust-lang#39469)
bors
added a commit
that referenced
this pull request
Feb 5, 2017
alexcrichton
added
the
beta-nominated
brson
added
the
beta-accepted
|
Accepted for beta. Small patch. |
Merged
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Mar 2, 2017
[beta] next - #39913 - #39730 - #39674 - #39602 - #39586 - #39471 - #39980 - #40020 - #40135 @nikomatsakis [this commit](3787d33) did not pick cleanly. You might peek at it. I took the liberty of accepting all the nominations myself, but the [packed struct alignment](#39586) PR is quite large. It did pick fine though and there's a comment there suggesting it works on beta cc @rust-lang/compiler. cc @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.