correct version in which more_struct_aliases was/will be stable #39552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stabilizing commit is 5056a43, which is not in 1.14, but is (at time of writing) on the 1.16 beta branch.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
zackmdavis
added a commit
to zackmdavis/Leafline
that referenced
this pull request
Feb 5, 2017
$ rustc --version rustc 1.17.0-nightly (0648517fa 2017-02-03) I was taken aback by the version number in the lint alerting me that more_struct_aliases is stable now: warning: this feature has been stable since 1.14.0. Attribute no longer needed, #[warn(stable_features)] on by default --> src/main.rs:1:12 | 1 | #![feature(more_struct_aliases, non_ascii_idents, pattern, plugin, test)] | ^^^^^^^^^^^^^^^^^^^ 1.14?!—but my last nightly-bump of this codebase was more recent than that; why didn't I get the warning then?! Subsequent investigation led to the submission of rust-lang/rust#39552.
|
@bors r+ rollup |
|
📌 Commit 5e06aee has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 5, 2017
…ilization_version, r=petrochenkov correct version in which more_struct_aliases was/will be stable The stabilizing commit is 5056a43, which is not in 1.14, but is (at time of writing) on the 1.16 beta branch. [See discussion](rust-lang#39282 (comment)).
bors
added a commit
that referenced
this pull request
Feb 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stabilizing commit is 5056a43, which is not in 1.14, but is (at
time of writing) on the 1.16 beta branch. See discussion.