Merge master into feature/release_6_0_0

[alifeee]

Done apart from one test fails. Not sure why.

[alifeee]

This test fails

gspread/tests/worksheet_test.py

Lines 148 to 172 in fc336cb

	@pytest.mark.vcr()
	def test_get_values_merge_cells_outside_of_range(self):
	self.sheet.resize(4, 4)
	sheet_data = [
	["1", "2", "4", ""],
	["down", "", "", ""],
	["", "", "2", ""],
	["num", "val", "", "0"],
	]
	self.sheet.update("A1:D4", sheet_data)
	self.sheet.merge_cells("A2:A3")
	self.sheet.merge_cells("C1:D2")
	REQUEST_RANGE = "A1:B2"
	expected_values = [
	["1", "2"],
	["down", ""],
	]
	values_with_merged = self.sheet.get_values(
	REQUEST_RANGE, combine_merged_cells=True
	)
	self.assertEqual(values_with_merged, expected_values)

With the failure:

        if response.ok:
            return response
        else:
>           raise APIError(response)
E           gspread.exceptions.APIError: {'code': 400, 'message': 'Invalid value 
at \'data.values\' (type.googleapis.com/google.protobuf.ListValue), "A1:D4"', 'status': 'INVALID_ARGUMENT', 'details': [{'@type': 'type.googleapis.com/google.rpc.BadRequest', 'fieldViolations': [{'field': 'data.values', 'description': 'Invalid value at \'data.values\' (type.googleapis.com/google.protobuf.ListValue), "A1:D4"'}]}]}

Looks like setting the initial data isn't working.

Ok, I realised this was because update switched values. This was hard to spot. Maybe we should catch this in v6 and raise a GspreadException if the arguments are the wrong way round

[alifeee]

I have merged master into feature/release_6_0_0

Pending @lavigne958's review. See changed files.

[lavigne958]

Ok, I realised this was because update switched values. This was hard to spot. Maybe we should catch this in v6 and raise a GspreadException if the arguments are the wrong way round

hum true that 🤔 do we have a way to validate that ? something like checking the type of the values may be ?

[alifeee]

hum true that 🤔 do we have a way to validate that ? something like checking the type of the values may be ?

I think we can do that. Could you create another issue to track it?