-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v16.7.0 release proposal #39782
v16.7.0 release proposal #39782
Commits on Aug 16, 2021
-
perf_hooks: web performance timeline compliance
All API introduced in this PR are compliant with web [performance-timeline](https://w3c.github.io/performance-timeline) spec. "performance-timeline" is listed as supported web spec in the doc https://nodejs.org/docs/latest/api/perf_hooks.html#perf_hooks_performance_measurement_apis. Changes summary: 1. Add new supported wpt test subsets: user-timing and performance-timeline. 2. Add support for `Performance.getEntries`, `Performance.getEntriesByName` and `Performance.getEntriesByType` to synchronously fetch buffered performance entries. This means the user should invoke `Performance.clearMarks` and `Performance.clearMeasures` to clear buffered entries to prevent from those entries been kept alive forever. 3. Add support (again after #37136) for `buffered` flags for `PerformanceObserver`. 3. Fixes `PerformanceMark` and `PerformanceMeasure` wpt compliance issues. 4. Only user-created performance entries will be buffered globally. This behavior should be compliant with https://w3c.github.io/timing-entrytypes-registry/#registry. With the new ability to fetch user-created performance entries synchronously, the issues raised in nodejs/diagnostics#464 (comment) could also be fixed. PR-URL: #39297 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 64c02eb - Browse repository at this point
Copy the full SHA 64c02ebView commit details -
doc: add PerformanceObserver
buffered
documentThe option buffered is not about queueing the PerformanceEntrys with an event loop task or not. The option buffered in the spec is about filling the observer with the global PerformanceEntry buffer. The current (and the spec) behavior is different with Node.js version <= v16.0.0. PR-URL: #39514 Refs: https://w3c.github.io/performance-timeline/#observe-method Refs: https://nodejs.org/dist/latest-v14.x/docs/api/perf_hooks.html#perf_hooks_performanceobserver_observe_options Refs: #39297 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7d0c869 - Browse repository at this point
Copy the full SHA 7d0c869View commit details -
George does not appear to be active in Node.js for quite some time (correction welcome!) and my attempts to get in touch have failed. PR-URL: #39539 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: George Adams <george.adams@microsoft.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for e428972 - Browse repository at this point
Copy the full SHA e428972View commit details -
tools: update ESLint to 7.31.0
Update ESLint to 7.31.0 PR-URL: #39424 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for af1c782 - Browse repository at this point
Copy the full SHA af1c782View commit details -
meta: update collaborator email in AUTHORS/.mailmap
Update email for Zeyu Yang. PR-URL: #39521 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 23bc4cf - Browse repository at this point
Copy the full SHA 23bc4cfView commit details -
meta: update collaborator email in README
Update email for Shelley Vohr to correspond to what is specified in .mailmap and what is used in more recently authored commits. PR-URL: #39521 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 72af147 - Browse repository at this point
Copy the full SHA 72af147View commit details -
meta: update collaborator email in AUTHORS/.mailmap
Update email for Ujjwal Sharma. PR-URL: #39521 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 110c088 - Browse repository at this point
Copy the full SHA 110c088View commit details -
doc: add code example to
http.createServer
methodPR-URL: #39455 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3ff5e15 - Browse repository at this point
Copy the full SHA 3ff5e15View commit details -
doc: add code example to
fs.truncate
methodPR-URL: #39454 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2129ad6 - Browse repository at this point
Copy the full SHA 2129ad6View commit details -
http: decodes url.username and url.password for authorization header
This change properly decodes the url.username and url.password for the authorization header constructed from the URL object for http(s) requests. Fixes: #31439 PR-URL: #39310 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 54dd3df - Browse repository at this point
Copy the full SHA 54dd3dfView commit details -
async_hooks: merge resource_symbol with owner_symbol
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #38468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a80c989 - Browse repository at this point
Copy the full SHA a80c989View commit details -
src: add cosmetic space character to
async_wrap.h
filePR-URL: #39459 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 60a2b31 - Browse repository at this point
Copy the full SHA 60a2b31View commit details -
build: use lts shorthand in GitHub Actions
Rather than hard-coding GitHub Actions to use Node.js 14.x, use the `lts/*` shorthand for "most recent LTS version". PR-URL: #39538 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eeb804a - Browse repository at this point
Copy the full SHA eeb804aView commit details -
meta: add .mailmap entry to remove duplication in AUTHORS
PR-URL: #39559 Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 86d144c - Browse repository at this point
Copy the full SHA 86d144cView commit details -
doc: update backport labels in release guide
Add `backport-open-v1.x,backported-to-v1.x` labels to `branch-diff` commands as these indicate pull requests that are being manually backported and should not be cherry-picked. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0bd97e1 - Browse repository at this point
Copy the full SHA 0bd97e1View commit details -
doc: fence command examples in release guide
Put the command examples for finding and replacing the `REPLACEME` tags into code fences so that they are more easily copiable when viewing the guide in the GitHub web UI. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8eccb11 - Browse repository at this point
Copy the full SHA 8eccb11View commit details -
doc: remove outdated ARM information from release guide
We no longer produced ARMv6 builds, and the ARMv7 builds are now cross compiled and are as quick as builds on the other platforms. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5df74f9 - Browse repository at this point
Copy the full SHA 5df74f9View commit details -
doc: move
NODE_MODULE_VERSION
in release guideMove the section on `NODE_MODULE_VERSION` into the section for major releases as it should only be updated for a major release. Add a note to remove the `-pre` suffix from the registry for the release commit. PR-URL: #39544 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0c0412e - Browse repository at this point
Copy the full SHA 0c0412eView commit details -
meta: add .mailmap entries to remove AUTHORS duplicates
PR-URL: #39560 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6f4a2aa - Browse repository at this point
Copy the full SHA 6f4a2aaView commit details -
meta: update .mailmap to remove duplication in AUTHORS
PR-URL: #39561 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b43f87d - Browse repository at this point
Copy the full SHA b43f87dView commit details -
doc: add
String.prototype.at
and%TypedArray%.prototype.at
PR-URL: #39583 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Ash Cripps <acripps@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 55f47cc - Browse repository at this point
Copy the full SHA 55f47ccView commit details -
perf_hooks: fix performance timeline wpt failures
PR-URL: #39532 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Configuration menu - View commit details
-
Copy full SHA for b37575b - Browse repository at this point
Copy the full SHA b37575bView commit details -
doc: add code examples to
Writable.destroy()
andWritable.destroyed
PR-URL: #39491 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8072517 - Browse repository at this point
Copy the full SHA 8072517View commit details -
PR-URL: #39587 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 60ab111 - Browse repository at this point
Copy the full SHA 60ab111View commit details -
meta: add mailmap entry for ttzztztz
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 16d85f3 - Browse repository at this point
Copy the full SHA 16d85f3View commit details -
meta: add mailmap entry for garygsc
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate entry. PR-URL: #39588 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 96d8ecb - Browse repository at this point
Copy the full SHA 96d8ecbView commit details -
build: exclude markdown files from some GitHub Actions
Ignore all markdown files when determining if test-asan, coverage-*, and test-macos need to run. Refs: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#patterns-to-match-file-paths PR-URL: #39565 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 9d38400 - Browse repository at this point
Copy the full SHA 9d38400View commit details -
meta: align README/.mailmap/AUTHORS email entries
The email address for Weijia Wang in the AUTHORS and .mailmap files is different from the email address in the README.md file. Based on their GitHub profile and commit metadata, the one in the README.md file is the preferred email. Updating .mailmap and AUTHORS to reflect it. PR-URL: #39505 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
Configuration menu - View commit details
-
Copy full SHA for 6b664e2 - Browse repository at this point
Copy the full SHA 6b664e2View commit details -
doc: add missing
introduced_in
metadataFixes doc build warnings: ``` Failed to add alternative version links to webstreams Failed to add alternative version links to async_context ``` PR-URL: #39575 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d7c8c6d - Browse repository at this point
Copy the full SHA d7c8c6dView commit details -
doc: update min mac ver + move mac arm64 to tier 1
Update the minimum macos version that can compile to match the xcode requirements. Also move mac arm64 to tier 1. refs: #39584 (comment) PR-URL: #39586 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7514405 - Browse repository at this point
Copy the full SHA 7514405View commit details -
Configuration menu - View commit details
-
Copy full SHA for cff2aea - Browse repository at this point
Copy the full SHA cff2aeaView commit details -
lib: use ERR_ILLEGAL_CONSTRUCTOR
Use ERR_ILLEGAL_CONSTRUCTOR error instead of `illegal constructor` or `Illegal constructor` TypeError. PR-URL: #39556 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 058e882 - Browse repository at this point
Copy the full SHA 058e882View commit details -
debugger: remove undefined parameter
The data parameter of unpackError() is typically undefined. PR-URL: #39570 Refs: https://github.com/nodejs/node-inspect/issues/101 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6c375e1 - Browse repository at this point
Copy the full SHA 6c375e1View commit details -
test: add test-debugger-breakpoint-exists
This adds test coverage to `unpackError()` in `lib/internal/debugger/inspect_client.js`. That function previously was untested. PR-URL: #39570 Refs: https://github.com/nodejs/node-inspect/issues/101 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 635e1a0 - Browse repository at this point
Copy the full SHA 635e1a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 016b7ba - Browse repository at this point
Copy the full SHA 016b7baView commit details -
module: add some typings to
internal/modules/esm/resolve
PR-URL: #39504 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4df59bc - Browse repository at this point
Copy the full SHA 4df59bcView commit details -
stream: add readableDidRead if has been read from
Adds did read accessor used to determine whether a readable has been read from. PR-URL: #39589 Refs: nodejs/undici#907 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9e38fc6 - Browse repository at this point
Copy the full SHA 9e38fc6View commit details -
test: convert anonymous function to arrow function
PR-URL: #39604 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1962c7c - Browse repository at this point
Copy the full SHA 1962c7cView commit details -
meta: add mailmap entry for dmabupt
This consolidates two email addresses/entries in AUTHORS into one. PR-URL: #39596 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fd213ed - Browse repository at this point
Copy the full SHA fd213edView commit details -
meta: add mailmap entry for uttampawar
This consolidates two email addresses/entries in AUTHORS into one. PR-URL: #39596 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 34f4bb8 - Browse repository at this point
Copy the full SHA 34f4bb8View commit details -
meta: add mailmap entry for ryzokuken
This consolidates two email addresses/entries in AUTHORS into one. PR-URL: #39596 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c59e3ec - Browse repository at this point
Copy the full SHA c59e3ecView commit details -
test: deflake test-http2-buffersize
This is basically a revert of c452632. The problem with that commit is that the promises returned by `once(server, 'stream')` are all resolved with the same stream when the first `'stream'` event is emitted. Refs: #39525 (comment) PR-URL: #39591 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 3622fb1 - Browse repository at this point
Copy the full SHA 3622fb1View commit details -
tools: update ESLint to 7.32.0
PR-URL: #39602 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d1360fc - Browse repository at this point
Copy the full SHA d1360fcView commit details -
PR-URL: #39629 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1474a9d - Browse repository at this point
Copy the full SHA 1474a9dView commit details -
meta: consolidate emails for timruffles
PR-URL: #39611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0920a8c - Browse repository at this point
Copy the full SHA 0920a8cView commit details -
meta: consolidate emails for timcosta
PR-URL: #39611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bb88c38 - Browse repository at this point
Copy the full SHA bb88c38View commit details -
meta: consolidate emails for tadhgcreedon
PR-URL: #39611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4ec5d2d - Browse repository at this point
Copy the full SHA 4ec5d2dView commit details -
Remove unnecessary name specificity in mailmap entries. AUTHORS is unchanged after running update-authors.js with these changes. PR-URL: #39612 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 7a91d4b - Browse repository at this point
Copy the full SHA 7a91d4bView commit details -
inspector: update inspector_protocol to 8ec18cf
Apply 8ec18cf: "Support STRING16 in the template when converting CBOR map keys" Refs: https://chromium.googlesource.com/deps/inspector_protocol/+/8ec18cf0885bef0b5c2a922c5dc3813cbf63e962 We're over 2 years out of date in the tools/inspector_protocol directory and I have to imagine this will come back to bite us at some point. But I also don't want to do a huge update all at once, so starting with a single commit. I might bundle commits together a bit more if this goes well. PR-URL: #39614 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 793fee4 - Browse repository at this point
Copy the full SHA 793fee4View commit details -
tools: improve error detection in find-inactive-collaborators
Previously, if the script failed to find a collaborator section in the README file, it would carry on with no results and no error. This detects the problem and throws an error. It is also more robust in that it will still work if the emeriti section ends up getting moved and does not immedaitely follow the collaborator section. PR-URL: #39617 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b1b6f20 - Browse repository at this point
Copy the full SHA b1b6f20View commit details -
node-api: handle pending exception in cb wrapper
fixes: nodejs/node-addon-api#1025 The functionreference test from the node-api tests was reporting a failed v8 check when Node.js was compiled as debug. The failure was because an exception was pending but the C++ wrappers were returning a return value that was invalid. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #39476 Fixes: nodejs/node-addon-api#1025 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b585858 - Browse repository at this point
Copy the full SHA b585858View commit details -
PR-URL: #39636 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f413a9d - Browse repository at this point
Copy the full SHA f413a9dView commit details -
Notable changes: - win,tcp: make `uv_close()` work more like unix. - cleanup,win: Remove `_WIN32` guards on threadpool. - more errno mappings and fixes. - higher performance try-writes. - fix string encoding issue of `uv_os_gethostname()` (note: MINGW-W64 upstream is broken on i686 due to https://sourceforge.net/p/mingw-w64/bugs/899/). - zOS support. - Workarounds for a `copy_file_range()` kernel bug. - Better support for TSan. - darwin: use `RLIMIT_STACK` for fsevents pthread. - fix a bug that would cause libuv to hang if the user called `uv_shutdown()`. - darwin: fix `uv_barrier()` race condition. PR-URL: #39525 Fixes: #39502 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cf5e5b5 - Browse repository at this point
Copy the full SHA cf5e5b5View commit details -
doc: add point to ask H1 reporter about credit
This commit updates the security release process document with a bullet point to ask the HackerOne reporter if they would like to be credited for reporting the vulnerability. We might also be able to add a question like this to the HackerOne template when a report is created, but it would still be good to have this bullet point to remember to include the information in the security release blog post. PR-URL: #39585 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9ab5503 - Browse repository at this point
Copy the full SHA 9ab5503View commit details -
debugger: prevent simultaneous heap snapshots
Fixes: #39555 PR-URL: #39638 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3321b65 - Browse repository at this point
Copy the full SHA 3321b65View commit details -
inspector: update inspector_protocol to 89c4adf
Apply a366321, 37518ac, and 89c4adf to tools/inspector_protocol. Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39650 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 81e62f6 - Browse repository at this point
Copy the full SHA 81e62f6View commit details -
crypto: implement webcrypto.randomUUID
Refs: https://wicg.github.io/uuid/ Refs: https://www.chromestatus.com/feature/5689159362543616 PR-URL: #39648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 93a904d - Browse repository at this point
Copy the full SHA 93a904dView commit details -
test: pull Web Platform Tests for WebCryptoAPI
PR-URL: #39648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 952a528 - Browse repository at this point
Copy the full SHA 952a528View commit details -
The `state` argument was unused. PR-URL: #39645 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 975edf5 - Browse repository at this point
Copy the full SHA 975edf5View commit details -
PR-URL: #39666 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 760cafa - Browse repository at this point
Copy the full SHA 760cafaView commit details -
dns: add "tries" option to Resolve options
PR-URL: #39610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for c7e918b - Browse repository at this point
Copy the full SHA c7e918bView commit details -
doc: add missing change to resolver ctor
PR-URL: #39610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 88c83a4 - Browse repository at this point
Copy the full SHA 88c83a4View commit details -
src: fix align in cares_wrap.h
Co-authored-by: James M Snell <jasnell@gmail.com> PR-URL: #39610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a00ef5 - Browse repository at this point
Copy the full SHA 2a00ef5View commit details -
test: use template to concatenate string
PR-URL: #39621 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0be15ce - Browse repository at this point
Copy the full SHA 0be15ceView commit details -
doc: fix color contrast issue in light mode
There is a color contrast issue with links in light mode on the API highlight background. This only appears in modules.md. This change fixes it without introducing other contrast issues in either light or dark mode. Previously, the color contrast for some text on modules.html was failing WCAG AA in light mode. PR-URL: #39660 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Configuration menu - View commit details
-
Copy full SHA for 4700f1e - Browse repository at this point
Copy the full SHA 4700f1eView commit details -
stream: utility consumers for web and node.js streams
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39594 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f57a0e4 - Browse repository at this point
Copy the full SHA f57a0e4View commit details -
doc: update debugger.md description and examples
The console captures in debugger.md are out of date, showing the wrapper: function (exports, require, module, __filename, __dirname) { That wrapper is no longer shown in debug sessions. This also shortens and simplifies the description of the debugger in the lede. PR-URL: #39661 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f5200f9 - Browse repository at this point
Copy the full SHA f5200f9View commit details -
test: increase memory for coverage action
PR-URL: #39690 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9f5acfa - Browse repository at this point
Copy the full SHA 9f5acfaView commit details -
build: fix V8 build with pointer compression
Refs: nodejs/TSC#790 (comment) PR-URL: #39664 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Configuration menu - View commit details
-
Copy full SHA for cf028df - Browse repository at this point
Copy the full SHA cf028dfView commit details -
doc: change "Version 4 UUID" to "version 4 UUID"
Refs: https://www.rfc-editor.org/rfc/rfc4122.txt PR-URL: #39682 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 08b31f1 - Browse repository at this point
Copy the full SHA 08b31f1View commit details -
test: fix test-debugger-heap-profiler for workers
Fix `sequential/test-debugger-heap-profiler` so that it can be run in a worker thread. `process.chdir()` is not allowed in worker threads but passing a current working directory into a spawned child process is allowed. PR-URL: #39687 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 34a041a - Browse repository at this point
Copy the full SHA 34a041aView commit details -
tools: update inspector_protocol to fe0467fd105a
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 61c53f3 - Browse repository at this point
Copy the full SHA 61c53f3View commit details -
tools: update inspector_protocol to a53e96d31a2755eb16ca37
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6e19c16 - Browse repository at this point
Copy the full SHA 6e19c16View commit details -
Revert "tools: fix compiler warning in inspector_protocol"
This reverts commit ffb34b6. PR-URL: #39694 Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c6323d8 - Browse repository at this point
Copy the full SHA c6323d8View commit details -
tools: update inspector_protocol to 97d3146
To apply the diff cleanly, ffb34b6 had to be reverted. Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ee7142f - Browse repository at this point
Copy the full SHA ee7142fView commit details -
tools: update inspector_protocol to 39ca567
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8d509d8 - Browse repository at this point
Copy the full SHA 8d509d8View commit details -
tools: update inspector_protocol to e8ba1a7
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log PR-URL: #39694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b9510d2 - Browse repository at this point
Copy the full SHA b9510d2View commit details -
meta: consolidate email addresses for szmarczak
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for aaab209 - Browse repository at this point
Copy the full SHA aaab209View commit details -
meta: consolidate email addresses for tadjik1
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a76b635 - Browse repository at this point
Copy the full SHA a76b635View commit details -
meta: consolidate email addresses for MarshallOfSound
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 91008fb - Browse repository at this point
Copy the full SHA 91008fbView commit details -
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 67cfc66 - Browse repository at this point
Copy the full SHA 67cfc66View commit details -
meta: consolidate AUTHORS entries for samshull
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fc2a626 - Browse repository at this point
Copy the full SHA fc2a626View commit details -
meta: consolidate AUTHORS entries for robin-drexler
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5fe2827 - Browse repository at this point
Copy the full SHA 5fe2827View commit details -
meta: consolidate AUTHORS entries for Ayase-252
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 07351ed - Browse repository at this point
Copy the full SHA 07351edView commit details -
meta: consolidate AUTHORS entries for homosaur
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6c788b8 - Browse repository at this point
Copy the full SHA 6c788b8View commit details -
meta: consolidate AUTHORS entries for ooHmartY
PR-URL: #39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 07cadc4 - Browse repository at this point
Copy the full SHA 07cadc4View commit details -
bootstrap: call _undestroy() inside _destroy for stdout and stderr
This change makes `process.stdout` and `process.stderr` to be automatically undestroyed when ended/destrouyed, therefore making it always possible to write/console.log to stdout. Fixes: #39447 PR-URL: #39685 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 69a2a6b - Browse repository at this point
Copy the full SHA 69a2a6bView commit details -
test: update WPT common and resources
PR-URL: #39697 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 94381fb - Browse repository at this point
Copy the full SHA 94381fbView commit details -
PR-URL: #39697 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7e98845 - Browse repository at this point
Copy the full SHA 7e98845View commit details -
deps: V8: cherry-pick 81814ed44574
Original commit message: [promise] Avoid stack overflow with context promise hooks in C++ This was handled in JS but not in C++. Bug: chromium:236703, v8:11025 Change-Id: Ic9adc4ceb4d2af2614427fec459c3e950654572f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3074460 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#76125} Refs: v8/v8@81814ed PR-URL: #39719 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 103bf20 - Browse repository at this point
Copy the full SHA 103bf20View commit details -
Introduces recursive cp method, based on fs-extra implementation. PR-URL: #39372 Fixes: #35880 Refs: nodejs/tooling#98 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
Configuration menu - View commit details
-
Copy full SHA for 0dc167a - Browse repository at this point
Copy the full SHA 0dc167aView commit details -
buffer: add Blob.prototype.stream method and other cleanups
Adds the `stream()` method to get a `ReadableStream` for the `Blob`. Also makes some other improvements to get the implementation closer to the API standard definition. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39693 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Configuration menu - View commit details
-
Copy full SHA for 091a579 - Browse repository at this point
Copy the full SHA 091a579View commit details -
test: enable blob.prototype.stream tests
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39693 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Configuration menu - View commit details
-
Copy full SHA for 53cf53c - Browse repository at this point
Copy the full SHA 53cf53cView commit details -
url,buffer: implement URL.createObjectURL
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39693 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Configuration menu - View commit details
-
Copy full SHA for 37dda19 - Browse repository at this point
Copy the full SHA 37dda19View commit details -
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: #39595 PR-URL: #39605 Refs: #39595 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 486d51a - Browse repository at this point
Copy the full SHA 486d51aView commit details -
Configuration menu - View commit details
-
Copy full SHA for be2d60d - Browse repository at this point
Copy the full SHA be2d60dView commit details -
Used more validators for the sake of consistency. PR-URL: #39663 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c68415c - Browse repository at this point
Copy the full SHA c68415cView commit details -
doc: fixed variable names in queueMicrotask example
fixed variable name in queueMicrotask where url variable was used instead of key PR-URL: #39634 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for bfb1dc0 - Browse repository at this point
Copy the full SHA bfb1dc0View commit details -
Original commit message: tools: fix compiler warning in inspector_protocol error: comparison of integer expressions of different signedness: ‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Werror=sign-compare] 2562 | if (!success || std::numeric_limits<int32_t>::max() < | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ 2563 | token_start_internal_value_) { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ PR-URL: #37573 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> PR-URL: #39725 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 77f9c1f - Browse repository at this point
Copy the full SHA 77f9c1fView commit details -
tools: fix more build warnings in inspector_protocol
PR-URL: #39725 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 52a172f - Browse repository at this point
Copy the full SHA 52a172fView commit details -
build: run coverage for inspector protocol changes
The inspector protocol currently lives in `tools`. PR-URL: #39725 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 097d898 - Browse repository at this point
Copy the full SHA 097d898View commit details -
src: fix crash in AfterGetAddrInfo
Remove invalid usage of `Check()`. This addresses: FATAL ERROR: v8::FromJust Maybe value is Nothing. 1: 0x101311bf5 node::Abort() (.cold.1) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 2: 0x1000ade29 node::Abort() [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 3: 0x1000adf8f node::OnFatalError(char const*, char const*) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 4: 0x1001f42d0 v8::V8::FromJustIsNothing() [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 5: 0x1000268e2 node::cares_wrap::(anonymous namespace)::AfterGetAddrInfo(uv_getaddrinfo_s*, int, addrinfo*)::$_2::operator()(bool, bool) const [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 6: 0x10002657c node::cares_wrap::(anonymous namespace)::AfterGetAddrInfo(uv_getaddrinfo_s*, int, addrinfo*) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 7: 0x1009fb388 uv__work_done [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 8: 0x100a00453 uv__async_io [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 9: 0x100a140cc uv__io_poll [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 10: 0x100a009c1 uv_run [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 11: 0x10014aca0 node::worker::Worker::Run() [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 12: 0x10014e56f node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 13: 0x7fff703d42eb _pthread_body [/usr/lib/system/libsystem_pthread.dylib] 14: 0x7fff703d7249 _pthread_start [/usr/lib/system/libsystem_pthread.dylib] 15: 0x7fff703d340d thread_start [/usr/lib/system/libsystem_pthread.dylib] PR-URL: #39735 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9046e78 - Browse repository at this point
Copy the full SHA 9046e78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 338a166 - Browse repository at this point
Copy the full SHA 338a166View commit details -
lib: use helper for readability
Used an extra `checkReusedHandle()` helper function to increase readability. PR-URL: #39649 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2751cdf - Browse repository at this point
Copy the full SHA 2751cdfView commit details -
lib: cleanup instance validation
Cleaned up the `URLSearchParams`'s `this` validation to increase readability by moving them to an extra helper function. PR-URL: #39656 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cc08d30 - Browse repository at this point
Copy the full SHA cc08d30View commit details -
Used the `validateInteger()` validator to cleanup validation and keep consistency. PR-URL: #39652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ca3cb96 - Browse repository at this point
Copy the full SHA ca3cb96View commit details -
tools: update path-parse in markdown linter package-lock file
Refs: GHSA-hj48-42vr-x3v9 PR-URL: #39729 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for eb74125 - Browse repository at this point
Copy the full SHA eb74125View commit details -
src: fix TextDecoder final flush size calculation
Flushing a TextDecoder with a zero-sized input and pending incomplete characters was failing when fatal: false. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39737 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 03be967 - Browse repository at this point
Copy the full SHA 03be967View commit details -
stream: ensure text() stream consumer flushes correctly
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39737 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cd9b0bf - Browse repository at this point
Copy the full SHA cd9b0bfView commit details -
buffer: add endings option, remove Node.js specific encoding option
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5bc31ea - Browse repository at this point
Copy the full SHA 5bc31eaView commit details -
tools: bump remark-preset-lint-node to 3.0.0
PR-URL: #39755 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5e10112 - Browse repository at this point
Copy the full SHA 5e10112View commit details -
Some of the validators can be simplified by removing unnecessary object parameters and using validators in another validators to keep consistency. PR-URL: #39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5afdc1f - Browse repository at this point
Copy the full SHA 5afdc1fView commit details -
dgram: use simplified validator
The `dgram` lib module should use the simplified `validatePort()` validator. PR-URL: #39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5f92d2f - Browse repository at this point
Copy the full SHA 5f92d2fView commit details -
The validators test should use the simplified `validateArray()` validator. PR-URL: #39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a5ded4a - Browse repository at this point
Copy the full SHA a5ded4aView commit details -
policy: fix integrity when DEFAULT_ENCODING is set
PR-URL: #39750 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7ff2139 - Browse repository at this point
Copy the full SHA 7ff2139View commit details -
doc: fix typo in hmac.paramNames default
PR-URL: #39766 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f18bb2a - Browse repository at this point
Copy the full SHA f18bb2aView commit details -
doc: correct cjs code to match mjs code
PR-URL: #39509 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5d66646 - Browse repository at this point
Copy the full SHA 5d66646View commit details -
worker: add brand checks for detached properties/methods
Add proper brand-checking for detached property and method accesses. Also adds a note about non-standard APIs and makes the standard accessors enumerable. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39763 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for dcab88a - Browse repository at this point
Copy the full SHA dcab88aView commit details
Commits on Aug 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d5987f8 - Browse repository at this point
Copy the full SHA d5987f8View commit details